Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom highlight support #1133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daniellandau
Copy link

Although #1101 has similar goals, the implementation is different.

@daniellandau
Copy link
Author

Um, the Travis build seems to fail on something Bloodhound related, and I didn't touch anything there.

@daniellandau
Copy link
Author

It would be nice to get some feedback on whether the underlying idea here is fundamentally within this projects scope. Updating my PR for changes in master took a non-negligible amount of work, and if there is no chance to get this merged, I will save the trouble of doing it again. ping @jharding

@bronson
Copy link

bronson commented Aug 19, 2015

I'd suggest squashing the two commits into one. Other than that, this PR looks good.

I sure need this functionality. Wish @jharding would take a look at it or call for help.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Daniel Landau
❌ daniellandau


Daniel Landau seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bronson
Copy link

bronson commented Jul 26, 2019

Project has been dead for 4 years but make sure to sign the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants