Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - show currect number of async suggestions when less than limit [Fix #1218] #1224

Closed
wants to merge 1 commit into from

Conversation

joekur
Copy link

@joekur joekur commented May 8, 2015

See #1218

@kylecrum
Copy link

Same as #1212 and #1233 . There are several solutions to choose from 😄

@vvo
Copy link

vvo commented Jun 3, 2015

hello @jharding, current typeahead completely fails because of this. It's already released on npm, jsdelivr etc.. but still fails.

Thanks for the work thought.

@vvo
Copy link

vvo commented Jun 11, 2015

Wonderful

@joekur
Copy link
Author

joekur commented Jun 11, 2015

@wkornewald - to clarify, are you saying my suggested change gives the wrong results? Could you elaborate? Maybe there is an additional test that's needed?

At this point I think @jharding just needs to choose the best implementation and close the rest of these pulls.

@wkornewald
Copy link

@joekur Actually, yours is correct and simpler than mine. Was in a hurry and my solution uses Math.min() to be on the safe side, but that's not really necessary.

@dougaxe1 dougaxe1 mentioned this pull request Jul 31, 2015
@cstoneham
Copy link

Is this going in? I ran into this issue recently.

@joekur
Copy link
Author

joekur commented Dec 7, 2015

@cstoneham see #1424

@cstoneham
Copy link

@joekur Ah, thanks for the heads up.

@joekur joekur closed this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants