Fixing bug when suggestions length is less than the limit #1501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug occurs when the number of suggestions is less than the limit.
Before, async update would give back
suggestions.slice(0, limit - rendered)
but in cases where number of rendered suggestions is lessthan limit, this would result in missing suggestions.
e.g. Say the limit is 5 and the list of suggestions for my query
"foo"
comes back as
["food", "fool", "foot"]
, this would result in appending["food", "fool", "foot"].splice(0, 5 - 3) //=> ["food", "fool"]
whichis missing the legitimate suggestion "foot".
Also in setting this up locally I scratched my head for a bit before figuring out that I needed to install Bower and run
bower install
. Updated the README to include those instructions.