Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong number of suggestions displayed sometimes #1578

Closed
wants to merge 1 commit into from

Conversation

slim
Copy link

@slim slim commented Oct 15, 2016

When you set the limit: param to number of suggestions and the results from ajax are less than limit: the number of suggestions displayed was actually - .
This is a shift by one bug.

It's a one line fix. I did not compile and include dist files in the fix to keep fix clear.

When you set the limit: param to number of suggestions and the results from ajax are less than limit: the number of suggestions displayed was actually <limit> - <results count>.
This is a shift by one bug.
@vigorouscoding
Copy link

vigorouscoding commented Nov 2, 2016

This is a duplicate of the PR (#1566) I created a while back.
I don't mean to be rude and I appreciate your work very much but we should probably have only one PR around.
In my PR there is already some activity and someone kindly created a test case to reproduce the bug easily.

@tangopium
Copy link

If I look at the number of PR and Issues, the slow response of the authors seems to me the bigger problem here.

@jlbooker
Copy link
Contributor

jlbooker commented Nov 13, 2016

Duplicate of #1212

Check out this fork, where we've fixed this issue: https://github.com/corejavascript/typeahead.js

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@slim slim closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants