Fix deprecation warnings #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, fix deprecation warning message for tests by updating Buffer, add package-lock to .gitignore
twolfson
reviewed
Oct 23, 2024
package.json
Outdated
| @@ -28,6 +28,7 @@ | |||
| "lint": "eslint src/ src-test/ --max-warnings 0", | |||
| "test": "npm run precheck && mocha src-test/ --timeout 60000 --reporter dot && npm run lint" | |||
| }, | |||
| "overrides": { "tough-cookie": "~4.1.3" }, | |||
There was a problem hiding this comment.
Is it wise to put an overrides in a package? This seems like people should do on a per-project basis, not me as a package maintainer
There was a problem hiding this comment.
i.e. Thoughts on making this as a workaround explained in #93 until get-pixels puts out a proper release?
There was a problem hiding this comment.
Thats a fair workaround. Definitely your call as the package maintainer - removed the override.
There was a problem hiding this comment.
Cool, thanks! I'll post a comment to #93 with attribution to you then =)
ChrisdeWolf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve moderate severity npm audit warning with tough-cookie override