Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #96

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix deprecation warnings #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d6a3cf
resolve moderate severity npm audit warning with tough-cookie overrid…
ChrisdeWolf Oct 23, 2024
f88da5b
remove override from package.json
ChrisdeWolf Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/node_modules
/src-test/actual_files
/scratch
/scratch
package-lock.json
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"lint": "eslint src/ src-test/ --max-warnings 0",
"test": "npm run precheck && mocha src-test/ --timeout 60000 --reporter dot && npm run lint"
},
"overrides": { "tough-cookie": "~4.1.3" },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it wise to put an overrides in a package? This seems like people should do on a per-project basis, not me as a package maintainer

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. Thoughts on making this as a workaround explained in #93 until get-pixels puts out a proper release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a fair workaround. Definitely your call as the package maintainer - removed the override.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! I'll post a comment to #93 with attribution to you then =)

"dependencies": {
"concat-stream": "~1.5.1",
"layout": "~2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src-test/smith_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ describe('An empty array', function () {

it('has no errors', spritesmithUtils.assertNoError());
it('renders an empty spritesheet', function () {
assert.deepEqual(this.result.image, new Buffer(0));
assert.deepEqual(this.result.image, Buffer.alloc(0));
});
it('returns an empty coordinate mapping', function () {
assert.deepEqual(this.result.coordinates, {});
Expand Down