Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use python string templates instead of ad hoc for classpath in kernelspecs #5859

Closed
scottdraves opened this issue Aug 17, 2017 · 1 comment
Closed

use python string templates instead of ad hoc for classpath in kernelspecs #5859

scottdraves opened this issue Aug 17, 2017 · 1 comment
Assignees
@rbidas

Comments

@scottdraves
Copy link
Contributor

https://github.com/twosigma/beakerx/blob/master/beakerx/beakerx/install.py#L43
this means using something other than __PATH__ in the kernel.json files.
@scottdraves
Copy link
Contributor Author

scottdraves commented Aug 18, 2017 •
edited
Loading

__MAIN_CLASS__ should be done similarly.

rbidas added a commit that referenced this issue Sep 15, 2017
@rbidas
#5859 change __PATH__
ee629f0
rbidas added a commit that referenced this issue Sep 15, 2017
@rbidas
#5859 change __MAIN_CLASS__
2884905
rbidas added a commit that referenced this issue Sep 18, 2017
@rbidas
#5859 PR changes
bd3e504
rbidas added a commit that referenced this issue Sep 18, 2017
@rbidas
#5859 merge from master
d108750
rbidas added a commit that referenced this issue Sep 19, 2017
@rbidas
#5859 PR changes
b4168ce
rbidas added a commit that referenced this issue Sep 19, 2017
@rbidas
#5859 fix build on windows
e4f0d90
scottdraves pushed a commit that referenced this issue Sep 19, 2017
@rbidas @scottdraves
#5859 Use python string templates instead of ad hoc for classpath in …
82d2d04 
…kernelspecs (#5981)

* #5859 change __PATH__

* #5859 change __MAIN_CLASS__

* #5864 classpath not properly quoted

* #5859 PR changes

* #5859 PR changes

* #5859 fix build on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbidas rbidas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottdraves @rbidas