Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classpath not properly quoted #5864

Closed
scottdraves opened this issue Aug 18, 2017 · 1 comment
Closed

classpath not properly quoted #5864

scottdraves opened this issue Aug 18, 2017 · 1 comment
Assignees
@rbidas
Milestone
beta

Comments

@scottdraves
Copy link
Contributor

on windows backslashes are not quoted in the kernel.json files.
scottdraves added a commit that referenced this issue Aug 18, 2017
@scottdraves
fix #5864 by quoting the classpath with json.dumps and removing the q…
33c1c4f 
…uotes from the templates
scottdraves added a commit that referenced this issue Aug 20, 2017
@scottdraves
workaround #5864
6e69334
@scottdraves scottdraves added this to the 0.1 milestone Aug 20, 2017
michalgce added a commit that referenced this issue Aug 21, 2017
@michalgce
Merge remote-tracking branch 'origin/master' into mariusz/5481
2708b05 
* origin/master: (21 commits)
  better source linking, fix missing rel instruction
  bump version to 0.2.4
  bump version to 0.2.3
  workaround #5864
  fix error setupbase.py on windows (#5863)
  bump version to 0.2.2, fix #5861
  also install our config for the kernelspec manager
  install our custom css, update author email and website url, add keywords
  install nbextension, rename entry point for installer, document in readme
  Leif/fix packaging (#5857)
  Fix "kernels" cmd (#5849)
  update version, correct location of version file
  #5726: use pypi instead of github (#5797)
  #5810 Fixed lsmagic output. (#5839)
  #5782 allow setting dpi for png export (#5841)
  #5909 Fixed Magic import with no arg. (#5840)
  jarek/5780: reduce duplication in evaluators  (#5788)
  #5767 add links to jvm-repr doc, improve tablesaw doc (#5835)
  remove "Table Saw"
  #5597 make widgets publishable (#5830)
  ...

# Conflicts:
#	beakerx/js/webpack.config.js
#	beakerx/setup.py
@scottdraves
Copy link
Contributor Author

we have workaround but still need the real fix #5865

michalgce added a commit that referenced this issue Aug 22, 2017
@michalgce
Merge remote-tracking branch 'origin/master' into michal/5847
94aff9e 
* origin/master:
  polish docs (#5872)
  #5844 - %import with no arguments - fix (#5852)
  Scala interfaces: List to Seq (#5853)
  add e2e tests for plotFeatures notebook (#5856)
  move conda download links to the main page
  #5845: fix grape, add ivy dependency (#5869)
  Revert "#5481 Update to ipywidgets v7 (#5770)" (#5870)
  #5481 Update to ipywidgets v7 (#5770)
  explain install situation betterg
  better source linking, fix missing rel instruction
  bump version to 0.2.4
  bump version to 0.2.3
  workaround #5864
  fix error setupbase.py on windows (#5863)
  bump version to 0.2.2, fix #5861
  also install our config for the kernelspec manager
  install our custom css, update author email and website url, add keywords
  install nbextension, rename entry point for installer, document in readme
  Leif/fix packaging (#5857)
  Fix "kernels" cmd (#5849)

# Conflicts:
#	kernel/base/src/main/java/com/twosigma/beakerx/kernel/commands/MagicCommand.java
michalgce added a commit that referenced this issue Aug 24, 2017
@michalgce
Merge remote-tracking branch 'origin/master' into michal/5843
31337b9 
* origin/master: (24 commits)
  jarek/groovy autocomplete (#5868)
  add explanation, remove outdated error msg
  remove old text
  #5847 %defaultDatasource crashes SQL kernel fix. (#5851)
  polish docs (#5872)
  #5844 - %import with no arguments - fix (#5852)
  Scala interfaces: List to Seq (#5853)
  add e2e tests for plotFeatures notebook (#5856)
  move conda download links to the main page
  #5845: fix grape, add ivy dependency (#5869)
  Revert "#5481 Update to ipywidgets v7 (#5770)" (#5870)
  #5481 Update to ipywidgets v7 (#5770)
  explain install situation betterg
  better source linking, fix missing rel instruction
  bump version to 0.2.4
  bump version to 0.2.3
  workaround #5864
  fix error setupbase.py on windows (#5863)
  bump version to 0.2.2, fix #5861
  also install our config for the kernelspec manager
  ...

# Conflicts:
#	kernel/base/src/main/java/com/twosigma/beakerx/kernel/commands/MagicCommand.java
@scottdraves scottdraves modified the milestones: 0.2, 0.1 Sep 1, 2017
rbidas added a commit that referenced this issue Sep 15, 2017
@rbidas
#5864 classpath not properly quoted
fabc753
scottdraves pushed a commit that referenced this issue Sep 19, 2017
@rbidas @scottdraves
#5859 Use python string templates instead of ad hoc for classpath in …
82d2d04 
…kernelspecs (#5981)

* #5859 change __PATH__

* #5859 change __MAIN_CLASS__

* #5864 classpath not properly quoted

* #5859 PR changes

* #5859 PR changes

* #5859 fix build on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbidas rbidas

Labels
None yet
Projects
None yet
Milestone
beta
Development

No branches or pull requests
2 participants
@scottdraves @rbidas