#6314 Replace nodejs installation with conda. #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalgce
force-pushed
the
michal/6314
branch
2 times, most recently
from
c02c2e4 to
b3fecae
Compare
|
it should install nodejs with conda, where is that? |
|
Opss, added. |
michalgce
force-pushed
the
michal/6314
branch
from
365ad6e to
5ebf310
Compare
michalgce
force-pushed
the
michal/6314
branch
from
5ebf310 to
2fd65a8
Compare
scottdraves
reviewed
Nov 20, 2017
docker/base/Dockerfile
Outdated
| ########## | ||
| # Node # | ||
| ########## | ||
| RUN conda install -y -c conda-forge nodejs |
There was a problem hiding this comment.
consolidate with the other conda install, it's best to minimize the number of Docker commands.
combine the apt-get and conda installs as much as possible.
There was a problem hiding this comment.
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices
"Minimize the number of layers"
scottdraves
added a commit
that referenced
this pull request
Nov 20, 2017
scottdraves
added a commit
that referenced
this pull request
Nov 20, 2017
michalgce
added a commit
that referenced
this pull request
Nov 21, 2017
* origin/master: add link to new doc to table of contents #6314 Fixed docker building. (#6357) fix link, close #6262 Revert "#6314 Replace nodejs installation with conda. (#6331)" (#6355) #6314 Replace nodejs installation with conda. (#6331) #6307: add banner to DateUtil (#6354) Serializer type name for anonymous classes (#6345) #6321: add matches method to MagicCommandFunctionality (#6353) #6343 Added Ivy to Groovy dependency. (#6350) jarek/5816: add load magic command (#6334) #6292 show yAxisR when set (#6312) # Conflicts: # doc/StartHere.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.