Serializer type name for anonymous classes #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool thanks i will test this shortly. |
michalgce
added a commit
that referenced
this pull request
Nov 21, 2017
* origin/master: add link to new doc to table of contents #6314 Fixed docker building. (#6357) fix link, close #6262 Revert "#6314 Replace nodejs installation with conda. (#6331)" (#6355) #6314 Replace nodejs installation with conda. (#6331) #6307: add banner to DateUtil (#6354) Serializer type name for anonymous classes (#6345) #6321: add matches method to MagicCommandFunctionality (#6353) #6343 Added Ivy to Groovy dependency. (#6350) jarek/5816: add load magic command (#6334) #6292 show yAxisR when set (#6312) # Conflicts: # doc/StartHere.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #6344. A helper static method is introduced that walks up the class chain to find a usable class name. Existing Java tests are modified and a Scala test is added.