-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give test more memory #2568
give test more memory #2568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2568 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 361 361
Lines 6630 6630
Branches 289 289
=======================================
Hits 6308 6308
Misses 322 322 Continue to review full report at Codecov.
|
@@ -34,6 +34,7 @@ lazy val commonSettings = Seq( | |||
}, | |||
resolvers ++= Seq(Resolver.sonatypeRepo("releases"), Resolver.sonatypeRepo("snapshots")), | |||
fork in test := true, | |||
test / javaOptions := Seq("-Xmx6G"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6GB is the max that our Travis instances have, right? We probably need to leave a little extra memory room for non-Java heap memory consumption on the instance, don't we?
I see this warning when running tests locally: |
The Travis machine we use has 7.5GB. So we have some room left. |
I've restarted a lot of builds that failed with OOM in the past couple of days. I don't know whether it's happening more often than before or not, but it's worth keeping an eye on. |
I noticed that the test is running in fork and was using the default java options.
This setting change shall boost it's max memory to 6GB, according to travis, we have 7.5 G on the machine.