Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fork test #2580

Closed
wants to merge 1 commit into from
Closed

Conversation

kailuowang
Copy link
Contributor

follow up for #2568
This seems to be the correct setting.

@kailuowang kailuowang requested a review from ceedubs October 23, 2018 02:56
@ceedubs
Copy link
Contributor

ceedubs commented Oct 23, 2018

Oh haha we submitted basically the same PR at the same time 😆 .

We have a couple of slight differences. Does the Test / test difference matter? Also does it make sense to have the argument in Java settings for JS?

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #2580 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2580   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         361      361           
  Lines        6630     6630           
  Branches      289      289           
=======================================
  Hits         6308     6308           
  Misses        322      322

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9069dbb...24cbacd. Read the comment docs.

@kailuowang
Copy link
Contributor Author

yeah, I think yours makes more sense.

@kailuowang kailuowang closed this Oct 23, 2018
@kailuowang kailuowang deleted the fix-fork-test branch October 23, 2018 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants