Add twitter emoji #2149
Merged
Add twitter emoji #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging ed59b6d into e4e7996 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 2f08c8a into 16fc158 - view on LGTM.com new alerts:
|
ariedro
added a commit
to el-ultimo-labs/web
that referenced
this pull request
May 16, 2022
This reverts commit 39875ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we've had emoji support determined entirely by the server host, so you would have to bring your own files and shortcodes. Part of the idea was to let different servers pick different styles (it was common in user-made plug.dj extensions to support different emoji themes). But the API for it is kinda bad and it's annoying to have to do this for a basic feature. There also just aren't that many emoji themes that you can legally use AND that are relatively complete.
Twitter emoji fit in pretty okay with the üWave theme, include recent additions to the emoji spec, and are free to use with attribution.
This PR adds twitter emoji by default. For a start it uses the EmojiOne shortcodes (which is the set I think every server so far has ended up using). I'll deploy this on wlk.yt and see how it goes, if we're happy this will be the actual initial implementation, otherwise I will work on the todo comments in the PR. Namely separating the implementation for custom and builtin emoji and supporting the unicode for builtin emoji.
Fixes #1172