Firefox: uBO logger does not report all the scriptlets #2072

ghajini · 2022-03-31T09:04:47Z

Prerequisites

I performed a cursory search of the issue tracker to avoid opening a duplicate issue
The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

uBO is the only extension
using a new, unmodified browser profile

Description

logger doesn't report following filters

vidbam.org##+js(abort-current-script, JSON.parse, break;case $.)
vidshar.org##+js(acis, JSON.parse, break;case $.)

when going here https://4hdmovie.com/movies/valimai-2022-tamil/ in firefox stable

iam not able to see #@# in logger to except the scriptlet filter ,this is how it looks in firefox

this is in opera browser

❌ doesn't appear in filter logger content area in firefox

opera looks like this

A specific URL where the issue occurs

https://4hdmovie.com/movies/valimai-2022-tamil/

Steps to Reproduce

Going https://4hdmovie.com/movies/valimai-2022-tamil/ and observing logger for above mentioned steps in description

Expected behavior

logger should report

vidbam.org##+js(abort-current-script, JSON.parse, break;case $.)
vidshar.org##+js(acis, JSON.parse, break;case $.)

show #@# next to scriptlet filter when visualized and X in filter logger content area

these are all behaviours reported in chromium based ublock origin

Actual behavior

Doesn't logged scriptlet filters and not shown #@# , X

Configuration

uBlock Origin: 1.41.8
Firefox: 98
filterset (summary):
network: 81322
cosmetic: 42192
scriptlet: 16444
html: 631
listset (total-discarded, last updated):
default:
user-filters: 1-0, never
ublock-filters: 31066-40, 40m
ublock-badware: 3993-3, 40m
ublock-privacy: 210-0, 40m
ublock-abuse: 72-0, 40m
ublock-unbreak: 1753-0, 40m
easylist: 65075-589, 40m
easyprivacy: 26738-577, 40m
urlhaus-1: 9225-0, 40m
plowe-0: 3690-2, 40m
ublock-quick-fixes: 138-4, 40m
filterset (user): [array of 1 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats:
allReadyAfter: 861 ms (selfie)
maxAssetCacheWait: 353 ms

The text was updated successfully, but these errors were encountered:

gorhill · 2022-03-31T11:33:30Z

logger doesn't report following filters

Because there are no iframes for either vidbam.org or vidshar.org. Scriptlets are injected in documents.

iam not able to see #@# in logger to except the scriptlet filter

modifiedHiddenSettings: [none]

filterAuthorMode

doesn't appear in filter logger content area in firefox

Browser behavior -- Firefox does not render a x in its input type="search" elements.

ghajini · 2022-03-31T12:31:13Z

Because there are no iframes for either vidbam.org or vidshar.org. Scriptlets are injected in documents.

i don't understand this ,there are iframes for vidshar.org/vidbam.org

i agree with 2 and 3rd point

gorhill · 2022-03-31T12:33:24Z

You told me:

when going here https://4hdmovie.com/movies/valimai-2022-tamil/ in firefox stable

It's what I did, I visited the provided URL and there were no frame reported in the logger. If you have a scenario where those frames become present in the DOM, please provide detailed steps to reproduce.

ghajini · 2022-03-31T12:43:23Z

Going here https://4hdmovie.com/movies/valimai-2022-tamil/
click under video sources fast stream & fast stream2 ,logger report frame request

but not scriptlet filter logging...

i think iam pretty much clearer

gorhill · 2022-03-31T13:06:49Z

click under video sources fast stream & fast stream2

Nothing happens when I click those links -- using new Firefox profile with only uBO installed with default settings and up to date lists.

mapx- · 2022-03-31T13:39:41Z

Nothing happens when I click those links -- using new Firefox profile with only uBO installed with default settings and up to date lists.

fast stream & fast stream2 are frozen using my european ip, then I tried a vpn us ip and are working
using us ip fast stream will directly open its embed stream (frame): https://vidshar.org/embed-gwtmm2hrazuv.html
fast stream2 => https://vidbam.org/embed-cltmyxvbt4hd.html
even without running / play the stream:

chrome => the filter is present in the logger

firefox => no such filter in the logger

gorhill · 2022-03-31T14:02:00Z

I tried 2 US VPN and still can't reproduce and links are unresponsive. Might require Windows OS? I don't have this.

mapx- · 2022-03-31T14:08:38Z

It's working using a Vancouver, Toronto, Montreal ip too

ghajini · 2022-03-31T14:13:06Z

use browsec vpn(autolocation ,netherland) @gorhill

gorhill · 2022-03-31T14:42:35Z

Scriptlets are injected in a different way in Firefox, declarative content script needs to be injected first in the frames, and when they execute, uBO's content script will ask the main process to inject the scriptlets. If declarative content script is not injected by Firefox, scriptlets won't be injected. In Chromium, uBO might report the scriptlet as injected, but it's not guaranteed it is happening.

I modified how scriptlet injection is reported in the logger in the next dev build: uBO will report scriptlet being injected only if it receives confirmation that the content script code injecting the scriptlets has been executed.

The links are also not functioning when using Chromium, so at this point I suspect the page's code depends on the OS, to be confirmed by someone else who can also test on linux.

Related issue: - uBlockOrigin/uBlock-issues#2072

ghajini · 2022-03-31T14:52:45Z

just an observation i can see evoload.io##+js(abort-on-property-write, _pop) in logger being reported on this link https://4hdmovie.com/movies/hey-sinamika-2022-hindi-hd/

but logger fails to report vidbam.org##+js(abort-current-script, JSON.parse, break;case $.)
vidshar.org##+js(acis, JSON.parse, break;case $.)
here link https://4hdmovie.com/movies/valimai-2022-tamil/

hope iam not offtopic

ghajini · 2022-03-31T15:33:02Z

@gorhill , with ubo 1.42.1b1 ,firefox
i think it broke ,now scriptlets are never reported
test link =any youtube video

gorhill · 2022-03-31T15:37:04Z

I will fix this asap.

mapx- · 2022-03-31T15:40:28Z

I installed ubuntu in hyper-v in windows, FF 75, uBO 1.42.1b0, canadian ip, I can get the same behaviour (scriptlet not reported for those 2 players above)

Regression from: - efe2e0c Related issue: - uBlockOrigin/uBlock-issues#2072

gorhill · 2022-03-31T15:56:47Z

Well I am not making this up, nothing happens when I click either of those links:

I will leave somebody else who can investigate code deal with this, use mention if ever there is something new of interest to me.

Error messages in Firefox 98.0.2 console in case they are meaningful, this on new browser profile with uBO last dev build with up to date filter lists + NY VPN:

mapx- · 2022-03-31T16:32:20Z

Toronto ip, FF + uBO 1.42.1b2, still same behaviour (no scriptlet logged for frames)

ghajini · 2022-04-03T12:23:10Z

another website where scriptlets not logged for iframes are

https://x.yesmovies.ws/attack-2021-hd-720p-tamil-movie-watch-online-tamilyogi-net/

these scriptlet(s)

vidshar.org##+js(acis, JSON.parse, break;case $.)
vadbom.com##+js(acis, JSON.parse, break;case $.)

stephenhawk8054 · 2022-04-04T01:17:32Z

another website where scriptlets not logged for iframes are

https://x.yesmovies.ws/attack-2021-hd-720p-tamil-movie-watch-online-tamilyogi-net/

these scriptlet(s)
vidshar.org##+js(acis, JSON.parse, break;case $.)
vadbom.com##+js(acis, JSON.parse, break;case $.)

Yes, I can confirm with this site

Screenshot

ghajini · 2022-04-04T14:17:44Z

@gorhill will you checkup, if this site in comment is accessible for you?
#2072 (comment)

gorhill · 2022-04-04T15:06:59Z

Yes, I can reproduce this with https://x.yesmovies.ws/attack-2021-hd-720p-tamil-movie-watch-online-tamilyogi-net/ -- no interaction needed. It's difficult to investigate but at first glance it appears uBO's content scripts are not injected in those two frames, maybe because they have sandbox attribute set on them. I would have to dig into bugzilla to find out if this is a known issues/normal behavior from Firefox's point of view. If that is the issue, then we will have to resort to HTML filtering if that is possible, otherwise if content scripts can't be injected, then it's not something I can fix in uBO. This requires more investigation though, as I said it's at first glance, it's not easy to investigate through the debugger, I need a custom version of uBO to confirm through console.log messages.

gorhill · 2022-04-04T15:37:40Z

I confirm that uBO's content scripts are not injected by Firefox, this is why the scriptlets are not injected as a consequence.

Top is Chroimum console, bottom is Firefox console:

ghajini · 2022-04-18T08:26:23Z

does this need to be reported to firefox or there's bugzilla issue about it?
@gwarser

gwarser · 2022-04-21T09:05:23Z

https://bugzilla.mozilla.org/show_bug.cgi?id=1411641

gorhill closed this as completed Mar 31, 2022

gorhill added the invalid not a uBlock issue label Mar 31, 2022

mapx- reopened this Mar 31, 2022

mapx- changed the title ~~UBo logger~~ uBO logger Firefox - does not report all the scriptlets Mar 31, 2022

mapx- removed the invalid not a uBlock issue label Mar 31, 2022

mapx- changed the title ~~uBO logger Firefox - does not report all the scriptlets~~ Firefox: uBO logger does not report all the scriptlets Mar 31, 2022

gorhill added a commit to gorhill/uBlock that referenced this issue Mar 31, 2022

Improve logger accuracy re. reported injected scriptlet

efe2e0c

Related issue: - uBlockOrigin/uBlock-issues#2072

gorhill added a commit to gorhill/uBlock that referenced this issue Mar 31, 2022

Fix scriptlets not being reported in logger (Firefox)

dd5a93d

Regression from: - efe2e0c Related issue: - uBlockOrigin/uBlock-issues#2072

krystian3w mentioned this issue Apr 5, 2022

alert-buster.js doesn't work on Firefox #2079

Closed

8 tasks

gwarser added external issue involving an external factor Firefox specific to Firefox labels Apr 17, 2022

gwarser closed this as completed Apr 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firefox: uBO logger does not report all the scriptlets #2072

Firefox: uBO logger does not report all the scriptlets #2072

ghajini commented Mar 31, 2022

gorhill commented Mar 31, 2022 •

edited

Loading

ghajini commented Mar 31, 2022 •

edited

Loading

gorhill commented Mar 31, 2022

ghajini commented Mar 31, 2022

gorhill commented Mar 31, 2022

mapx- commented Mar 31, 2022 •

edited

Loading

gorhill commented Mar 31, 2022

mapx- commented Mar 31, 2022 •

edited

Loading

ghajini commented Mar 31, 2022

gorhill commented Mar 31, 2022

ghajini commented Mar 31, 2022

ghajini commented Mar 31, 2022 •

edited

Loading

gorhill commented Mar 31, 2022

mapx- commented Mar 31, 2022

gorhill commented Mar 31, 2022 •

edited

Loading

mapx- commented Mar 31, 2022 •

edited

Loading

ghajini commented Apr 3, 2022 •

edited

Loading

stephenhawk8054 commented Apr 4, 2022

ghajini commented Apr 4, 2022

gorhill commented Apr 4, 2022

gorhill commented Apr 4, 2022

ghajini commented Apr 18, 2022

gwarser commented Apr 21, 2022

Firefox: uBO logger does not report all the scriptlets #2072

Firefox: uBO logger does not report all the scriptlets #2072

Comments

ghajini commented Mar 31, 2022

Prerequisites

I tried to reproduce the issue when...

Description

A specific URL where the issue occurs

Steps to Reproduce

Expected behavior

Actual behavior

Configuration

gorhill commented Mar 31, 2022 • edited Loading

ghajini commented Mar 31, 2022 • edited Loading

gorhill commented Mar 31, 2022

ghajini commented Mar 31, 2022

gorhill commented Mar 31, 2022

mapx- commented Mar 31, 2022 • edited Loading

gorhill commented Mar 31, 2022

mapx- commented Mar 31, 2022 • edited Loading

ghajini commented Mar 31, 2022

gorhill commented Mar 31, 2022

ghajini commented Mar 31, 2022

ghajini commented Mar 31, 2022 • edited Loading

gorhill commented Mar 31, 2022

mapx- commented Mar 31, 2022

gorhill commented Mar 31, 2022 • edited Loading

mapx- commented Mar 31, 2022 • edited Loading

ghajini commented Apr 3, 2022 • edited Loading

stephenhawk8054 commented Apr 4, 2022

ghajini commented Apr 4, 2022

gorhill commented Apr 4, 2022

gorhill commented Apr 4, 2022

ghajini commented Apr 18, 2022

gwarser commented Apr 21, 2022

gorhill commented Mar 31, 2022 •

edited

Loading

ghajini commented Mar 31, 2022 •

edited

Loading

mapx- commented Mar 31, 2022 •

edited

Loading

mapx- commented Mar 31, 2022 •

edited

Loading

ghajini commented Mar 31, 2022 •

edited

Loading

gorhill commented Mar 31, 2022 •

edited

Loading

mapx- commented Mar 31, 2022 •

edited

Loading

ghajini commented Apr 3, 2022 •

edited

Loading