Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

feature: optional git hooks #635

Merged

Conversation

ChristianMurphy
Copy link
Contributor

@ChristianMurphy ChristianMurphy commented Dec 1, 2017

closes #634, resolves #535, and fixes #633


Acknowledges in CONTRIBUTING.md that we're trying to do Conventional Commits.

Adds hints on how to locally lint commit messages and even on how to automate this.

Funny anecdote: The hook caught problems with my initial commit message attempt for both all three of these commits. Writing in Sentence case with a full stop. it's an ingrained habit.


This adds and documents a add-hooks script in package.json that installs husky for those who want git hooks but keeps hooks off by default.


Contributor License Agreement adherence:

@ChristianMurphy ChristianMurphy requested a review from a team December 1, 2017 19:56
@ChristianMurphy ChristianMurphy changed the title Feat/option githook feature: optional git hooks Dec 1, 2017
@ChristianMurphy ChristianMurphy merged commit 6885234 into uPortal-Attic:master Dec 4, 2017
@ChristianMurphy ChristianMurphy deleted the feat/option-githook branch December 4, 2017 15:58
@vertein vertein added this to the 8.0.0 milestone Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document commit message linting A plea to abolish commit hooks
3 participants