Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

feature: optional git hooks #635

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,7 @@ by continuous integration (e.g. Travis-CI) on pull requests.

You can locally lint (check for style compliance) your most recent commit message by `npm run lint-commit`.

You can locally lint your commit messages via a pre-commit hook by

1. Setting `"commitmsg": "commitlint -e",` in your local `package.json`
2. Having a `.git/commit-msg` script that honors the `package.json`
configuration on this point, e.g. via [Husky][].
You can locally lint your commit messages via a pre-commit hook by running `npm run add-hooks`.

[uportal-home website on incubating]: http://uportal-project.github.io/uportal-home/apereo-incubation.html
[Apereo inbound intellectual property licensing practices]: https://www.apereo.org/licensing/practices
Expand All @@ -53,5 +49,4 @@ configuration on this point, e.g. via [Husky][].
[Apereo CLA roster]: http://licensing.apereo.org/completed-clas
[Apereo Welcoming Policy]: https://www.apereo.org/content/apereo-welcoming-policy
[Conventional Commits]: https://conventionalcommits.org/
[Husky]: https://github.com/typicode/husky
[code of conduct]: ../CODE_OF_CONDUCT.md
80 changes: 20 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
"version": "7.0.0",
"description": "Application Framework for uPortal",
"scripts": {
"commitmsg": "commitlint -e",
"cz": "git-cz",
"add-hooks": "npm install husky --no-save",
"test": "karma start components/karma.conf.js --single-run",
"build-static": "node tools/static/build.js",
"lint-all": "npm run lint-js && npm run lint-md && npm run lint-commit && npm run lint-css",
Expand Down Expand Up @@ -88,7 +90,6 @@
"graceful-fs": "^4.0.0",
"greenkeeper-lockfile": "^1.12.0",
"htmlprocessor": "^0.2.4",
"husky": "^0.14.3",
"jasmine-core": "^2.3.4",
"karma": "1.7.1",
"karma-chrome-launcher": "2.2.0",
Expand Down