Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try distribution with google play #466

Open
4 of 5 tasks
uazo opened this issue Oct 26, 2023 · 52 comments
Open
4 of 5 tasks

Try distribution with google play #466

uazo opened this issue Oct 26, 2023 · 52 comments
Labels
help wanted Extra attention is needed / I am not capable of it / I would need task These are things I tell myself I should do working on it working on it

Comments

@uazo
Copy link
Owner

uazo commented Oct 26, 2023

  • Create signed aab
  • Generate upload key
  • Create privacy policy page
  • Review app permissions
  • Change urls in FRE
@uazo uazo added the task These are things I tell myself I should do label Oct 26, 2023
@uazo
Copy link
Owner Author

uazo commented Nov 1, 2023

see #489

@uazo
Copy link
Owner Author

uazo commented Nov 2, 2023

App Permission:
android.permission.ACCESS_COARSE_LOCATION, android.permission.ACCESS_FINE_LOCATION, android.permission.ACCESS_NETWORK_STATE, android.permission.ACCESS_WIFI_STATE, android.permission.BLUETOOTH, android.permission.BLUETOOTH_ADMIN, android.permission.BLUETOOTH_ADVERTISE, android.permission.BLUETOOTH_CONNECT, android.permission.BLUETOOTH_SCAN, android.permission.CAMERA, android.permission.CREDENTIAL_MANAGER_QUERY_CANDIDATE_CREDENTIALS, android.permission.CREDENTIAL_MANAGER_SET_ALLOWED_PROVIDERS, android.permission.CREDENTIAL_MANAGER_SET_ORIGIN, android.permission.DOWNLOAD_WITHOUT_NOTIFICATION, android.permission.FOREGROUND_SERVICE, android.permission.FOREGROUND_SERVICE_DATA_SYNC, android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK, android.permission.INTERNET, android.permission.MODIFY_AUDIO_SETTINGS, android.permission.NFC, android.permission.POST_NOTIFICATIONS, android.permission.QUERY_ALL_PACKAGES, android.permission.READ_EXTERNAL_STORAGE, android.permission.READ_MEDIA_AUDIO, android.permission.READ_MEDIA_IMAGES, android.permission.READ_MEDIA_VIDEO, android.permission.RECEIVE_BOOT_COMPLETED, android.permission.RECORD_AUDIO, android.permission.REORDER_TASKS, android.permission.REQUEST_INSTALL_PACKAGES, android.permission.USE_BIOMETRIC, android.permission.USE_FINGERPRINT, android.permission.VIBRATE, android.permission.WAKE_LOCK, android.permission.WRITE_EXTERNAL_STORAGE, com.android.launcher.permission.INSTALL_SHORTCUT, com.chrome.permission.DEVICE_EXTRAS, org.cromite.cromite.TOS_ACKED, org.cromite.cromite.permission.READ_WRITE_BOOKMARK_FOLDERS

some of them are useless and should be eliminated.

@uazo
Copy link
Owner Author

uazo commented Mar 13, 2024

I would need help producing images for the store.

they ask me:

  • App icon
    Your app icon must be a PNG or JPEG, up to 1 MB, 512 px by 512 px, and meet our design specifications and metadata policy
  • Feature graphic
    Your feature graphic must be a PNG or JPEG, up to 15 MB, and 1,024 px by 500 px
  • Phone screenshots
    Upload 2-8 phone screenshots. Screenshots must be PNG or JPEG, up to 8 MB each, 16:9 or 9:16 aspect ratio, with each side between 320 px and 3,840 px
  • Tablet 7-inch tablet screenshots
    Upload up to eight 7-inch tablet screenshots. Screenshots must be PNG or JPEG, up to 8 MB each, 16:9 or 9:16 aspect ratio, with each side between 320 px and 3,840 px
  • Tablet 10-inch tablet screenshots
    Upload up to eight 10-inch tablet screenshots. Screenshots must be PNG or JPEG, up to 8 MB each, 16:9 or 9:16 aspect ratio, with each side between 1,080 px and 7,680 px

@uazo uazo added the help wanted Extra attention is needed / I am not capable of it / I would need label Mar 13, 2024
@Pittvandewitt
Copy link

The app icon and the feature graphic can easily be generated in Android Studio. Could you point me to the SVG file in color? I wasn't able to find it in the repo.

@uazo
Copy link
Owner Author

uazo commented Mar 19, 2024

I am not able to create an svg.
there is, however, the one kindly created by @austinhuang0131

#429 (comment)

@Pittvandewitt
Copy link

App icon for the Play Store:
ic_launcher-playstore
Feature graphic variant 1:
feature_graphic_Cromite
Feature graphic variant 2:
feature_graphic_Cromite-Take_back_your_browser

For the screenshots, do you have something in mind for what content you want to be featured?

@olumolu
Copy link

olumolu commented Apr 16, 2024

When we can expect it to be available in playstore.?

@uazo
Copy link
Owner Author

uazo commented Apr 17, 2024

as soon as I can, I'm in no hurry.
First, however, I have to change the default settings and would like to share them before imposing them.

@olumolu
Copy link

olumolu commented Apr 17, 2024

I only have two requests one is post this app in flathub and also in playstore.

uazo added a commit that referenced this issue Oct 9, 2024
…t lists

Welcome screen: changed urls to better explain privacy policies (#466 #594)
@lucasmz-dev
Copy link

Since @uazo wanted to have Bitwarden trust the future Cromite play store builds I'll keep an out here tracking
It does mean some potential delay after it is released on the Play Store but if I am to do it I would like to wait until release to prevent potential issues

@uazo
Copy link
Owner Author

uazo commented Oct 11, 2024

of course @lucasmz-dev, you just have to be patient..
I am still missing a few open issues blocking

It would be nice to have a website too, but my artistry is really bad.

@abue-ammar
Copy link

of course @lucasmz-dev, you just have to be patient.. I am still missing a few open issues blocking

It would be nice to have a website too, but my artistry is really bad.

i can help building a site for cromite using reactjs (vite) / nextjs

@uazo
Copy link
Owner Author

uazo commented Oct 12, 2024

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well?
consider that a static site is enough for me for now.

@olumolu
Copy link

olumolu commented Oct 12, 2024

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well? consider that a static site is enough for me for now.

Foe static site hugo is a good option to consider

@abue-ammar
Copy link

abue-ammar commented Oct 12, 2024

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well? consider that a static site is enough for me for now.

since it will be static i don't think there will be too much graphics involved. simple and minimal would be great. if you have any example sites that you can provide me or any specific expectations you can tell me, i will make it. my English isn't so i will need help with intros and contents in there.

and if you want i can build just like bromite.org site but a more polished look removing news part and things we don't need

@abue-ammar
Copy link

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well? consider that a static site is enough for me for now.

Foe static site hugo is a good option to consider

i never tried hugo before. but i am thinking about some little interactivity like user can select their preferred download option, like desktop or android or arch.

@olumolu
Copy link

olumolu commented Oct 15, 2024

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well? consider that a static site is enough for me for now.

Foe static site hugo is a good option to consider

i never tried hugo before. but i am thinking about some little interactivity like user can select their preferred download option, like desktop or android or arch.

I understand but hugo is easy even i was looking into it and i find this to be easier than other projects and it will be even easier for your as you are a professional.
You just need to watch a tutorial video how it works.

@uazo
Copy link
Owner Author

uazo commented Oct 15, 2024

and if you want i can build just like bromite.org site but a more polished look removing news part and things we don't need

I would say that would be a very good start.

@abue-ammar
Copy link

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well? consider that a static site is enough for me for now.

Foe static site hugo is a good option to consider

i never tried hugo before. but i am thinking about some little interactivity like user can select their preferred download option, like desktop or android or arch.

I understand but hugo is easy even i was looking into it and i find this to be easier than other projects and it will be even easier for your as you are a professional. You just need to watch a tutorial video how it works.

i am comfortable with reactjs environment and tailwind css, so i can build faster with it. planning to use nextjs for better SEO

@abue-ammar
Copy link

and if you want i can build just like bromite.org site but a more polished look removing news part and things we don't need

I would say that would be a very good start.

thanks i will start building it! i will give you an update soon.

@uazo
Copy link
Owner Author

uazo commented Oct 15, 2024

i will give you an update soon.

There is no hurry, mind you!
and thanks :)

@olumolu
Copy link

olumolu commented Oct 15, 2024

@abdarker you are welcome!

i can help building a site for cromite using reactjs (vite) / nextjs

only at the development level, or are you able to do graphic and content proposals as well? consider that a static site is enough for me for now.

Foe static site hugo is a good option to consider

i never tried hugo before. but i am thinking about some little interactivity like user can select their preferred download option, like desktop or android or arch.

I understand but hugo is easy even i was looking into it and i find this to be easier than other projects and it will be even easier for your as you are a professional. You just need to watch a tutorial video how it works.

i am comfortable with reactjs environment and tailwind css, so i can build faster with it. planning to use nextjs for better SEO

Sure i would love to see progress thanks. How it looks.
Keep posting.

@uazo
Copy link
Owner Author

uazo commented Oct 16, 2024

@abdarker never used vercel.app. let me get this straight, is the source a github repo? is it possible to see which one? does the build generate a completely static site that I can take to cromite.org?

@abue-ammar
Copy link

@abdarker never used vercel.app. let me get this straight, is the source a github repo? is it possible to see which one? does the build generate a completely static site that I can take to cromite.org?

here's the repo https://github.com/abdarker/cromite-website . i made it public. we can build in GitHub and host in GitHub page and change domain. and yes it generates static site completely . even in vercel you can add custom domain.

@olumolu
Copy link

olumolu commented Oct 16, 2024

I like it.
There is a lack of install instructions like for android for linux so on...
Also multiple language support and a toggle or maybe based on browser dark mode and light mode switch.

@uazo
Copy link
Owner Author

uazo commented Oct 16, 2024

@abdarker thank you. i will try to generate the static site... (you force me to learn react, yet another language :)

@uazo
Copy link
Owner Author

uazo commented Oct 16, 2024

um... what it creates is not a -simple- static site, it is an ultra-optimised static site!
not good for what I want, the site must also be easy to read, I mean the code, no obfuscations, no indecipherable functions.
sorry.

@abue-ammar
Copy link

I like it. There is a lack of install instructions like for android for linux so on... Also multiple language support and a toggle or maybe based on browser dark mode and light mode switch.

it's not the final. but yeah need to put more instructions and some sub pages as well

@abue-ammar
Copy link

@abdarker thank you. i will try to generate the static site... (you force me to learn react, yet another language :)

it's veryyyy easy you can do it broo 😁

@abue-ammar
Copy link

abue-ammar commented Oct 16, 2024

um... what it creates is not a -simple- static site, it is an ultra-optimised static site! not good for what I want, the site must also be easy to read, I mean the code, no obfuscations, no indecipherable functions. sorry.

we can just set a github action and it will build and generate static site and run in prod. and yeah it is very optimized just few KB size. i used react because it would be easier to handle interactive download based on user's preference. page.tsx and download-selector.tsx contains all necessary html for now. if you want i can split each sections into multiple files/component

@olumolu
Copy link

olumolu commented Oct 16, 2024

I like it. There is a lack of install instructions like for android for linux so on... Also multiple language support and a toggle or maybe based on browser dark mode and light mode switch.

it's not the final. but yeah need to put more instructions and some sub pages as well

Most important feature is dark mode do consider

@n-ce
Copy link

n-ce commented Oct 16, 2024

I think react was a really bad choice in this case of a simple site. I think the requirement is an HTML first app. We don't need to make a single page application, just a static site with a bit of interactivity. We can use vanilla js or alpine.js for this case.
Start with a single HTML file.

@abue-ammar
Copy link

abue-ammar commented Oct 16, 2024

I think react was a really bad choice in this case of a simple site. I think the requirement is an HTML first app. We don't need to make a single page application, just a static site with a bit of interactivity. We can use vanilla js or alpine.js for this case. Start with a single HTML file.

well i built the project and it was only few KB if you check the network console. on first load it ships less than 20kb to the client after it's loaded it becomes few bytes. why not react? most of the people have misconception. well it's on @uazo now how he wants it.

@abue-ammar
Copy link

I like it. There is a lack of install instructions like for android for linux so on... Also multiple language support and a toggle or maybe based on browser dark mode and light mode switch.

it's not the final. but yeah need to put more instructions and some sub pages as well

Most important feature is dark mode do consider

that's easy. will keep that in mind.

@uazo
Copy link
Owner Author

uazo commented Oct 17, 2024

i'm not against react, but i don't want anyone to question that cromite's site does hidden things, considering that i could theoretically do them (which i won't, of course). therefore, everything must be extremely simple and clean.

@abue-ammar
Copy link

i'm not against react, but i don't want anyone to question that cromite's site does hidden things, considering that i could theoretically do them (which i won't, of course). therefore, everything must be extremely simple and clean.

https://github.com/abdarker/cromite-website/blob/master/app/page.tsx
https://github.com/abdarker/cromite-website/blob/master/app/download-selector.tsx these two files contains plain html and some js. nothing hidden. you can make ur repo public. it is even way simpler than https://github.com/bromite/bromite.github.io what bromite had hundreds of files and folders. so yeah

@uazo
Copy link
Owner Author

uazo commented Oct 17, 2024

some js. nothing hidden.

Details

image

this once the build has been done.

@abue-ammar
Copy link

some js. nothing hidden.

Details

image

this once the build has been done.

this is bundled js file. and dom related things. also routing etc. it happens after build. people can see everything in the repo before the build process, that there's nothing sketchy. after build it's split into optimized multiple chunks. mostly all modern framework does that. i don't think anyone would complain about that.

@Nemris
Copy link

Nemris commented Oct 17, 2024

@uazo I've never used it myself, but apparently https://hexo.io/ can be used to create very snappy, static sites.

@nirnejak
Copy link

nirnejak commented Nov 4, 2024

@uazo @abdarker how's the website dev going, would love to collaborate, I have good design skills too, I can help with copy and SEO as well.

@uazo
Copy link
Owner Author

uazo commented Nov 5, 2024

First we have to decide what to put on the site. At this time, I have no ideas.

@olumolu
Copy link

olumolu commented Nov 5, 2024

First we have to decide what to put on the site. At this time, I have no ideas.

For reference https://thorium.rocks/
https://brave.com/

@nirnejak
Copy link

nirnejak commented Nov 7, 2024

thanks @olumolu,
I'll create a rough draft of things to put on the side and share for feedback @uazo

@abue-ammar
Copy link

abue-ammar commented Nov 7, 2024

@uazo @abdarker how's the website dev going, would love to collaborate, I have good design skills too, I can help with copy and SEO as well.

i have built something minimal couple of weeks ago but it wasn't approved and didn't meet expectation https://cromite-website.vercel.app . open source app patch like Revanced also using svelte where i used nextjs . here is revanced's website https://github.com/revanced/revanced-website

@GfEW
Copy link

GfEW commented Dec 8, 2024

i'm not against react, but i don't want anyone to question that cromite's site does hidden things, considering that i could theoretically do them (which i won't, of course). therefore, everything must be extremely simple and clean.

Why not indeed use Hugo? In my view, your point is very valid. Clean code only before the build isn't enough to match the degree of trustworthiness your site gets from simple, readable html.

@olumolu
Copy link

olumolu commented Dec 8, 2024

i'm not against react, but i don't want anyone to question that cromite's site does hidden things, considering that i could theoretically do them (which i won't, of course). therefore, everything must be extremely simple and clean.

Why not indeed use Hugo? In my view, your point is very valid. Clean code only before the build isn't enough to match the degree of trustworthiness your site gets from simple, readable html.

Having a website is more important than whether use hugo or react first have a website and submit to google play after that improvements can be done.

@GfEW
Copy link

GfEW commented Dec 9, 2024

Having a website is more important than whether use hugo or react first have a website and submit to google play after that improvements can be done.

Sounds reasonable in general, but I'm not sure if I agree regarding the particular case of Cromite. Not only would those barely readable scripts built from react code keep raising questions until a better (i. e. simpler, more readable) solution was found, but the attitude "'works somehow' is OK for now, things can be improved later on" doesn't exactly help to promote a privacy focused, trust sensitive product - it could even stain the perception of the whole project.

Therefore, a clean, transparently understandable website may be preferable, even if setting it up takes a little longer than the quickest path. (Hugo is no behemoth, after all.)

@abue-ammar
Copy link

Having a website is more important than whether use hugo or react first have a website and submit to google play after that improvements can be done.

Sounds reasonable in general, but I'm not sure if I agree regarding the particular case of Cromite. Not only would those barely readable scripts built from react code keep raising questions until a better (i. e. simpler, more readable) solution was found, but the attitude "'works somehow' is OK for now, things can be improved later on" doesn't exactly help to promote a privacy focused, trust sensitive product - it could even stain the perception of the whole project.

Therefore, a clean, transparently understandable website may be preferable, even if setting it up takes a little longer than the quickest path. (Hugo is no behemoth, after all.)

having a site is more important. technology is advancing why not using modern framework. doesn't make any sense. if website built with modern framework makes you think it's something sketchy then github is also using reactjs. 🤷🏻‍♂️

@GfEW
Copy link

GfEW commented Dec 9, 2024

[...]

the attitude "'works somehow' is OK for now, things can be improved later on" doesn't exactly help to promote a privacy focused, trust sensitive product - it could even stain the perception of the whole project.
Therefore, a clean, transparently understandable website may be preferable, even if setting it up takes a little longer than the quickest path. (Hugo is no behemoth, after all.)

having a site is more important.

I don't mean to deny the importance of a proper web presence, nor to say the radical performance optimization provided by react was a bad thing per se. But to make sure we're not treating everything as a nail just because we like using hammers, could you name the merits that, in your view, outweigh the problems with a rushed, subpar (i. e. less transparent, more complex than needed) solution?

technology is advancing why not using modern framework.
[...]

As far as I understand @uazo's reservations outlined above, they are not generally dismissing modern frameworks, but instead asking for a solution that fits the specific needs of the Cromite project. If you think they are pointless, I guess we have a disagreement there.

if website built with modern framework makes you think it's something sketchy then github is also using reactjs. 🤷🏻‍♂️

At the end, this decision isn't about us easily understanding or trusting anything, but about website visitors doing so, including potential first-time users. Whilst I'd admit that "understandability" or even "simplicity" are very difficult topics when we're dealing with a codebase as unfathomably huge as that of Chromium, I think I've made my point. The decision, or priorization, is obviously up to @uazo.

@olumolu
Copy link

olumolu commented Jan 30, 2025

What is the status?

@uazo
Copy link
Owner Author

uazo commented Jan 31, 2025

What is the status?

I am not going to go out in the store until I have the automatic tests unit activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed / I am not capable of it / I would need task These are things I tell myself I should do working on it working on it
Projects
None yet
Development

No branches or pull requests

9 participants