-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try distribution with google play #466
Comments
see #489 |
App Permission: some of them are useless and should be eliminated. |
I would need help producing images for the store. they ask me:
|
The app icon and the feature graphic can easily be generated in Android Studio. Could you point me to the SVG file in color? I wasn't able to find it in the repo. |
I am not able to create an svg. |
When we can expect it to be available in playstore.? |
as soon as I can, I'm in no hurry. |
I only have two requests one is post this app in flathub and also in playstore. |
Since @uazo wanted to have Bitwarden trust the future Cromite play store builds I'll keep an out here tracking |
of course @lucasmz-dev, you just have to be patient..
It would be nice to have a website too, but my artistry is really bad. |
i can help building a site for cromite using reactjs (vite) / nextjs |
@abdarker you are welcome!
only at the development level, or are you able to do graphic and content proposals as well? |
Foe static site hugo is a good option to consider |
since it will be static i don't think there will be too much graphics involved. simple and minimal would be great. if you have any example sites that you can provide me or any specific expectations you can tell me, i will make it. my English isn't so i will need help with intros and contents in there. and if you want i can build just like bromite.org site but a more polished look removing news part and things we don't need |
i never tried hugo before. but i am thinking about some little interactivity like user can select their preferred download option, like desktop or android or arch. |
I understand but hugo is easy even i was looking into it and i find this to be easier than other projects and it will be even easier for your as you are a professional. |
I would say that would be a very good start. |
i am comfortable with reactjs environment and tailwind css, so i can build faster with it. planning to use nextjs for better SEO |
thanks i will start building it! i will give you an update soon. |
There is no hurry, mind you! |
Sure i would love to see progress thanks. How it looks. |
@abdarker never used vercel.app. let me get this straight, is the source a github repo? is it possible to see which one? does the build generate a completely static site that I can take to cromite.org? |
here's the repo https://github.com/abdarker/cromite-website . i made it public. we can build in GitHub and host in GitHub page and change domain. and yes it generates static site completely . even in vercel you can add custom domain. |
I like it. |
@abdarker thank you. i will try to generate the static site... (you force me to learn react, yet another language :) |
um... what it creates is not a -simple- static site, it is an ultra-optimised static site! |
it's not the final. but yeah need to put more instructions and some sub pages as well |
it's veryyyy easy you can do it broo 😁 |
we can just set a github action and it will build and generate static site and run in prod. and yeah it is very optimized just few KB size. i used react because it would be easier to handle interactive download based on user's preference. |
Most important feature is dark mode do consider |
I think react was a really bad choice in this case of a simple site. I think the requirement is an HTML first app. We don't need to make a single page application, just a static site with a bit of interactivity. We can use vanilla js or alpine.js for this case. |
well i built the project and it was only few KB if you check the network console. on first load it ships less than 20kb to the client after it's loaded it becomes few bytes. why not react? most of the people have misconception. well it's on @uazo now how he wants it. |
that's easy. will keep that in mind. |
i'm not against react, but i don't want anyone to question that cromite's site does hidden things, considering that i could theoretically do them (which i won't, of course). therefore, everything must be extremely simple and clean. |
https://github.com/abdarker/cromite-website/blob/master/app/page.tsx |
this is bundled js file. and dom related things. also routing etc. it happens after build. people can see everything in the repo before the build process, that there's nothing sketchy. after build it's split into optimized multiple chunks. mostly all modern framework does that. i don't think anyone would complain about that. |
@uazo I've never used it myself, but apparently https://hexo.io/ can be used to create very snappy, static sites. |
@uazo @abdarker how's the website dev going, would love to collaborate, I have good design skills too, I can help with copy and SEO as well. |
First we have to decide what to put on the site. At this time, I have no ideas. |
For reference https://thorium.rocks/ |
i have built something minimal couple of weeks ago but it wasn't approved and didn't meet expectation https://cromite-website.vercel.app . open source app patch like |
Why not indeed use Hugo? In my view, your point is very valid. Clean code only before the build isn't enough to match the degree of trustworthiness your site gets from simple, readable html. |
Having a website is more important than whether use hugo or react first have a website and submit to google play after that improvements can be done. |
Sounds reasonable in general, but I'm not sure if I agree regarding the particular case of Cromite. Not only would those barely readable scripts built from react code keep raising questions until a better (i. e. simpler, more readable) solution was found, but the attitude "'works somehow' is OK for now, things can be improved later on" doesn't exactly help to promote a privacy focused, trust sensitive product - it could even stain the perception of the whole project. Therefore, a clean, transparently understandable website may be preferable, even if setting it up takes a little longer than the quickest path. (Hugo is no behemoth, after all.) |
having a site is more important. technology is advancing why not using modern framework. doesn't make any sense. if website built with modern framework makes you think it's something sketchy then github is also using reactjs. 🤷🏻♂️ |
[...]
I don't mean to deny the importance of a proper web presence, nor to say the radical performance optimization provided by react was a bad thing per se. But to make sure we're not treating everything as a nail just because we like using hammers, could you name the merits that, in your view, outweigh the problems with a rushed, subpar (i. e. less transparent, more complex than needed) solution?
As far as I understand @uazo's reservations outlined above, they are not generally dismissing modern frameworks, but instead asking for a solution that fits the specific needs of the Cromite project. If you think they are pointless, I guess we have a disagreement there.
At the end, this decision isn't about us easily understanding or trusting anything, but about website visitors doing so, including potential first-time users. Whilst I'd admit that "understandability" or even "simplicity" are very difficult topics when we're dealing with a codebase as unfathomably huge as that of Chromium, I think I've made my point. The decision, or priorization, is obviously up to @uazo. |
What is the status? |
I am not going to go out in the store until I have the automatic tests unit activated. |
The text was updated successfully, but these errors were encountered: