CORS changes for OOD #1348
Closed
CORS changes for OOD #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven changed their download url
The pull request #967 added extra code to the report manager that manipulated the start and end times of charts in a report. This broke the report generator. These changes appear to not be necessary at all and must have been added by mistake.
The getRoleReport() decoding was manging the chart data. This is seen for charts that have either & or = in the config. For example: global_filters=%7B%22data%22%3A%5B%7B%22id%22%3A%22institution%3D400%22%2C%22value_id%22%3A%22400%22%2C%22dimension_id%22%3A%22institution%22%2C%22checked%22%3Atrue%7D%5D%2C%22total%22%3A1%7D
Cherry Pick important bugfixes from 8.6
Add CORS configuration
Use `postMessage` to alert `window.top`on framed login
Documentation Updates
return user supplied jobname in search
jpwhite4
reviewed
Jun 24, 2020
| @@ -84,6 +84,9 @@ public function __construct( | |||
| $this->addField(new TableField($factTable, 'end_time_ts')); | |||
| $this->addField(new FormulaField('-1', 'cpu_user')); | |||
|
|
|||
| // This is used by Integrations and not currently shown on the XDMoD interface | |||
There was a problem hiding this comment.
There will need to be a corresponding change to the supremm module too. Also can you check with Jeff to see if this interferes with his dw export changes
There was a problem hiding this comment.
This shouldn't cause any problems with the dw export.
jpwhite4
reviewed
Jun 24, 2020
jpwhite4
reviewed
Jun 24, 2020
jpwhite4
reviewed
Jun 24, 2020
jpwhite4
reviewed
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to merge what was going to be 8.7 into 9.0