Switch to provided jsr305 and nullability improvements #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes a feather out of Square's recent blog post and brings back the jsr305 dependency as a provided dependency. Benefits are static analysis and kotlin code still can leverage this. Main functional differences are annotating a `package-info` with `@ParametersAreNonnullByDefault` annotation and switching to javax' `@Nullable` annotation instead of RxJava's.
kageiit
approved these changes
May 12, 2017
| @@ -45,7 +45,8 @@ def kotlin = [ | |||
| ] | |||
|
|
|||
| def misc = [ | |||
| errorProneAnnotations: "com.google.errorprone:error_prone_annotations:${versions.errorProne}" | |||
| errorProneAnnotations: "com.google.errorprone:error_prone_annotations:${versions.errorProne}", | |||
| jsr305: 'com.google.code.findbugs:jsr305:3.0.2' | |||
There was a problem hiding this comment.
Can you be more specific?
There was a problem hiding this comment.
Add spaces after the jsr305 to match the width till the : on the previous line
There was a problem hiding this comment.
This project doesn't follow that pattern since it often damages git history
ZacSweers
added a commit
that referenced
this pull request
May 14, 2017
This is a followup to #69, and improves it in two main ways: - This adds it to subpackages as well, which I missed in the first pass. - Switches to a custom `PackageNonNull` annotation instead, which expands the checks to also include return types, fields, local vars, etc. It's pretty broad right now but we could reduce scope if need be. This is pulled into a separate artifact for re-use, but still only applied as compileOnly.
ZacSweers
added a commit
that referenced
this pull request
May 16, 2017
* More nullability annotation work This is a followup to #69, and improves it in two main ways: - This adds it to subpackages as well, which I missed in the first pass. - Switches to a custom `PackageNonNull` annotation instead, which expands the checks to also include return types, fields, local vars, etc. It's pretty broad right now but we could reduce scope if need be. This is pulled into a separate artifact for re-use, but still only applied as compileOnly. * Clean up qualifiers * Tweak name * Don't export artifact Not necessary, we'll make this a separate project later * CLASS retention instead of runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes inspiration from Square's recent blog post and brings back the jsr305 dependency as a provided dependency. Benefits are static analysis and kotlin code still can leverage this.
Main functional differences are annotating a
package-infowith@ParametersAreNonnullByDefaultannotation and switching to javax'@Nullableannotation instead of RxJava's.Thank you for contributing to AutoDispose. Before pressing the "Create Pull Request" button, please consider the following points:
Prior reading: