More nullability annotation work #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to #69, and improves it in two main ways: - This adds it to subpackages as well, which I missed in the first pass. - Switches to a custom `PackageNonNull` annotation instead, which expands the checks to also include return types, fields, local vars, etc. It's pretty broad right now but we could reduce scope if need be. This is pulled into a separate artifact for re-use, but still only applied as compileOnly.
kageiit
suggested changes
May 16, 2017
| @@ -0,0 +1,3 @@ | |||
| POM_NAME=AutoDispose (Provided) | |||
There was a problem hiding this comment.
why are we shipping this to maven? this is compileOnly
There was a problem hiding this comment.
Still needs to be available in sources jar for static analysis right?
|
LGTM. But unless you have public fields, the main change here is that the annotation means return types are |
|
the annotation applies to parameters, method return types, and fields in general, even private ones (though those only really matter for internal details) |
kageiit
suggested changes
May 16, 2017
| ElementType.METHOD, | ||
| ElementType.PARAMETER | ||
| }) | ||
| @Retention(RetentionPolicy.RUNTIME) |
There was a problem hiding this comment.
SOURCE retention please. Since this is not really shipped out to consumers
There was a problem hiding this comment.
I coped this from @ParametersAreNonnullByDefault, let me see if I can find the justification
msridhar
approved these changes
May 16, 2017
Not necessary, we'll make this a separate project later
kageiit
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #69, and improves it in two main ways:
PackageNonNullannotation instead, which expands the checks to also include return types, fields, local vars, etc. It's pretty broad right now but we could reduce scope if need be. This is pulled into a separate artifact for re-use, but still only applied as compileOnly.@ParametersAreNonnullByDefaultactually only covers method parameters it seems.