Skip to content

Commit

Permalink
fix(e2e): fix argument for az sig image-version create (#968)
Browse files Browse the repository at this point in the history
It appears there's been a regression in version 2.59.0 of the Azure CLI,
where az sig image-version create fails when being passed the
--managed-image flag, see the related [failing CI
run](https://github.com/ubuntu/adsys/actions/runs/8677801641/job/23793927248
), and the [reported
issue](Azure/azure-cli#28700) on the azure-cli
project.

Because of this we are not able to create new versions for any of our VM
templates.

To fix this we can apply the workaround from the linked issue and pass
the VM ID inside the `--virtual-machine` argument. I've tested this
locally and successfully created a new image version with the change.

Partly fixes UDENG-2528
  • Loading branch information
GabrielNagy authored Apr 24, 2024
2 parents af74ad4 + 2bd6870 commit 9521cc0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion e2e/cmd/build_base_image/02_create_vm_template/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func action(ctx context.Context, cmd *command.Command) error {
"--gallery-image-version", nextImageVersion,
"--target-regions", "westeurope", "eastus=1=standard_zrs",
"--replica-count", "2",
"--managed-image", inv.VMID,
"--virtual-machine", inv.VMID,
"--tags", "project=AD", "subproject=adsys-e2e-tests",
)
if err != nil {
Expand Down

0 comments on commit 9521cc0

Please sign in to comment.