fix(e2e): fix argument for az sig image-version create #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears there's been a regression in version 2.59.0 of the Azure CLI, where az sig image-version create fails when being passed the --managed-image flag, see the related failing CI run,[1] and the reported issue on the azure-cli project.[2] Because of this we are not able to create new versions for any of our VM templates. To fix this we can apply the workaround from the linked issue and pass the VM ID inside the `--virtual-machine` argument. [1] https://github.com/ubuntu/adsys/actions/runs/8677801641/job/23793927248 [2] Azure/azure-cli#28700
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 90.77% 90.77%
=======================================
Files 78 78
Lines 6886 6886
=======================================
Hits 6251 6251
Misses 621 621
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears there's been a regression in version 2.59.0 of the Azure CLI, where az sig image-version create fails when being passed the --managed-image flag, see the related failing CI run, and the reported issue on the azure-cli project.
Because of this we are not able to create new versions for any of our VM templates.
To fix this we can apply the workaround from the linked issue and pass the VM ID inside the
--virtual-machineargument. I've tested this locally and successfully created a new image version with the change.Partly fixes UDENG-2528