fix: move cheerio to dependencies (#2867)

* chore: cheerio move to dependencies * Create clean-walls-hang.md * chore: rebuild lock * chore: fix ci * chore: make prettier happy :) --------- Co-authored-by: Kuitos <[email protected]> Co-authored-by: 唯然 <[email protected]>
umijs · Dec 27, 2023 · 35f7863 · 35f7863
1 parent 86becdb
commit 35f7863
Show file tree

Hide file tree

Showing 5 changed files with 1,798 additions and 2,852 deletions.
diff --git a/.changeset/clean-walls-hang.md b/.changeset/clean-walls-hang.md
@@ -0,0 +1,5 @@
+---
+"@qiankunjs/webpack-plugin": patch
+---
+
+fix: move cheerio to dependencies
diff --git a/packages/sandbox/src/core/membrane/index.ts b/packages/sandbox/src/core/membrane/index.ts
@@ -148,8 +148,8 @@ export class Membrane {
         const actualTarget = propertiesWithGetter.has(p)
           ? incubatorContext
           : p in membraneTarget
-          ? membraneTarget
-          : incubatorContext;
+            ? membraneTarget
+            : incubatorContext;
         const value = actualTarget[p as never];
 
         // frozen value should return directly, see https://github.com/umijs/qiankun/issues/2015

diff --git a/packages/shared/src/fetch-utils/wrapFetchWithCache.ts b/packages/shared/src/fetch-utils/wrapFetchWithCache.ts
@@ -23,7 +23,7 @@ export const wrapFetchWithCache: (fetch: Fetch) => Fetch = (fetch) => {
   const lruCache = getGlobalCache();
 
   const cachedFetch: Fetch = (input, init) => {
-    const fetchInput = input as Parameters<Fetch>[0];
+    const fetchInput = input;
     const cacheKey = getCacheKey(fetchInput);
     const wrapFetchPromise = async (promise: Promise<Response>): Promise<Response> => {
       try {

diff --git a/packages/webpack-plugin/package.json b/packages/webpack-plugin/package.json
@@ -20,11 +20,11 @@
   "author": "Hermanna",
   "license": "MIT",
   "dependencies": {
-    "webpack-sources": "^3.2.3"
+    "webpack-sources": "^3.2.3",
+    "cheerio": "1.0.0-rc.12"
   },
   "devDependencies": {
     "@types/webpack-sources": "^3.2.1",
-    "cheerio": "1.0.0-rc.12",
     "webpack": "^4.0.0 || ^5.0.0"
   }
 }