Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cheerio move to dependencies #2867

Merged
merged 6 commits into from
Dec 27, 2023
Merged

fix: cheerio move to dependencies #2867

merged 6 commits into from
Dec 27, 2023

Conversation

qiYuei
Copy link
Contributor

@qiYuei qiYuei commented Dec 27, 2023

cheerio 应该放在 dependencies 才能正常运行
image

Copy link

vercel bot commented Dec 27, 2023

@qiYuei is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

Copy link

changeset-bot bot commented Dec 27, 2023

🦋 Changeset detected

Latest commit: a8cdf6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qiankunjs/webpack-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qiYuei
Copy link
Contributor Author

qiYuei commented Dec 27, 2023

@kuitos 可能要重新发布下这个

@kuitos
Copy link
Member

kuitos commented Dec 27, 2023

ci 修一下,pnpm lockfile 要更新

@qiYuei
Copy link
Contributor Author

qiYuei commented Dec 27, 2023

ci 修一下,pnpm lockfile 要更新

我在 create-qiankun 那个 pr 修了, 等那个 pr 合并还是在这里更新一次? 现在那边别的库 eslint 没过

image

@kuitos
Copy link
Member

kuitos commented Dec 27, 2023

先修这个,这两个不是一个问题

@qiYuei
Copy link
Contributor Author

qiYuei commented Dec 27, 2023

先修这个,这两个不是一个问题

Done

@kuitos kuitos merged commit 35f7863 into umijs:next Dec 27, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants