Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright check in CI #381

Merged
merged 38 commits into from
Nov 17, 2020
Merged

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Nov 6, 2020

Testing in personal fork using this testing PR that uses a testing branch in the personal fork. The testing branch layered on commits that added some extra debugging and some mock files (some which conform to license headers, some which do not). To see how it is working, you can look at the output from an invocation in the testing PR.

Closes #155

@echeran echeran requested a review from a team as a code owner November 6, 2020 00:59
@coveralls
Copy link

coveralls commented Nov 6, 2020

Pull Request Test Coverage Report for Build 65106277397da1a0497e530a8dd68371763c1ac9-PR-381

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.586%

Totals Coverage Status
Change from base Build 73f1d954dc2316e425014a4c68b0339f34ef9d47: 0.03%
Covered Lines: 3375
Relevant Lines: 4525

💛 - Coveralls

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Per #334, there is desire to make these checks runnable when not on CI. In #376, I moved some logic from build-test.yml into Makefile.toml. Can we structure the copyright check to be in a side script that hopefully runs cross-platform?

Duckscript, a Rust-based cross-platform scripting language, might help: https://github.com/sagiegurari/duckscript

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(setting review bit)

@sffc
Copy link
Member

sffc commented Nov 10, 2020

#376 is in now, so once you update your branch, you will be able to add this to Makefile.toml.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .cargo/config.toml is now changed in the branch
  • .github/workflows/build-test.yml is different
  • components/datetime/src/pattern/parser.rs is now changed in the branch
  • components/provider_fs/src/deserializer.rs is now changed in the branch
  • components/provider_fs/src/export/serializers/bincode.rs is now changed in the branch
  • components/provider_fs/src/export/serializers/mod.rs is now changed in the branch
  • components/provider/tests/sizes.rs is now changed in the branch
  • Makefile.toml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran requested a review from sffc November 13, 2020 00:52
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Did you verify that trigger_error in Duckscript causes the command to exit with a nonzero error code, such that it bubbles up to GitHub Actions?

@echeran
Copy link
Contributor Author

echeran commented Nov 13, 2020

I verified at the command line that it gives a nonzero exit code. I originally used exit but the duckscript process still exited with a successful 0 code, so I switched to trigger_error.

@echeran
Copy link
Contributor Author

echeran commented Nov 13, 2020

I should have mentioned that trigger_error exits the entire process because of the line at the top of the script to enable that behavior: exit_on_error true.

As an aside, it seems like Duckscript has mostly a prefix notation syntax. It's almost like S-exprs, just without outer parenthases.

@echeran echeran merged commit c43fd47 into unicode-org:master Nov 17, 2020
@echeran echeran deleted the ci-copyright-check branch June 17, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI copyright headers check
4 participants