-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copyright check in CI #381
Conversation
Pull Request Test Coverage Report for Build 65106277397da1a0497e530a8dd68371763c1ac9-PR-381
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Per #334, there is desire to make these checks runnable when not on CI. In #376, I moved some logic from build-test.yml into Makefile.toml. Can we structure the copyright check to be in a side script that hopefully runs cross-platform?
Duckscript, a Rust-based cross-platform scripting language, might help: https://github.com/sagiegurari/duckscript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(setting review bit)
#376 is in now, so once you update your branch, you will be able to add this to Makefile.toml. |
…ble quoted scalar
…ckscript in Makefile.toml
793a24a
to
a0684cd
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Did you verify that trigger_error
in Duckscript causes the command to exit with a nonzero error code, such that it bubbles up to GitHub Actions?
I verified at the command line that it gives a nonzero exit code. I originally used |
I should have mentioned that As an aside, it seems like Duckscript has mostly a prefix notation syntax. It's almost like S-exprs, just without outer parenthases. |
Testing in personal fork using this testing PR that uses a testing branch in the personal fork. The testing branch layered on commits that added some extra debugging and some mock files (some which conform to license headers, some which do not). To see how it is working, you can look at the output from an invocation in the testing PR.
Closes #155