AST Bugfix: correctly parsing TypeNameContext - slice of types (#183)

ast/constructor.go

@@ -2,7 +2,6 @@ package ast
 
 import (
 	"github.com/goccy/go-json"
-
 	ast_pb "github.com/unpackdev/protos/dist/go/ast"
 	"github.com/unpackdev/solgo/parser"
 )

ast/reference.go

@@ -158,7 +158,6 @@ func (r *Resolver) Resolve() []error {
 					uNode := r.UnprocessedNodes[nodeId]
 					uNode.ErrUpdateRef = true
 					r.UnprocessedNodes[nodeId] = uNode
-
 				}
 			} else {
 				uNode := r.UnprocessedNodes[nodeId]

ast/storage.go

@@ -78,6 +78,9 @@ func elementaryTypeSizeInBits(typeName string) (int64, bool) {
 // `bytes` with a fixed size, and dynamically sized types like `string` and `bytes`.
 // Returns the size and a boolean indicating if the type is recognized.
 func getTypeSizeInBits(typeName string) (int64, bool) {
+	// TODO: Make this actually work better... Figure out dynamically what is the size of an array
+	typeName = strings.TrimSuffix(typeName, "[]")
+
 	switch {
 	case typeName == "bool":
 		return 8, true

ast/tree.go

@@ -70,10 +70,6 @@ func (t *Tree) UpdateNodeReferenceById(nodeId int64, nodeRefId int64, typeRef *T
 		return false
 	}
 
-	/* 	if nodeId == 4186 || nodeRefId == 4186 {
-		panic("WHY?")
-	} */
-
 	for _, child := range t.astRoot.GetGlobalNodes() {
 		if n := t.byRecursiveReferenceUpdate(child, nodeId, nodeRefId, typeRef); n {
 			return n

ast/type_name.go

@@ -472,6 +472,7 @@ func (t *TypeName) parseElementaryTypeName(unit *SourceUnit[Node[ast_pb.SourceUn
 			t.TypeDescription = refTypeDescription
 		}
 	}
+
 }
 
 // parseIdentifierPath parses the IdentifierPath from the given IdentifierPathContext.
@@ -596,10 +597,12 @@ func (t *TypeName) parseMappingTypeName(unit *SourceUnit[Node[ast_pb.SourceUnit]
 func (t *TypeName) generateTypeName(sourceUnit *SourceUnit[Node[ast_pb.SourceUnit]], ctx any, parentNode *TypeName, typeNameNode *TypeName) *TypeName {
 	typeName := &TypeName{
 		ASTBuilder: t.ASTBuilder,
-		Id:         t.GetNextID(),
+		Id:         t.GetId(),
 		NodeType:   ast_pb.NodeType_ELEMENTARY_TYPE_NAME,
 	}
 
+	t.NodeType = ast_pb.NodeType_ELEMENTARY_TYPE_NAME
+
 	switch specificCtx := ctx.(type) {
 	case parser.IMappingKeyTypeContext:
 		typeName.Name = specificCtx.GetText()
@@ -764,7 +767,9 @@ func (t *TypeName) Parse(unit *SourceUnit[Node[ast_pb.SourceUnit]], fnNode Node[
 		case *parser.IdentifierPathContext:
 			t.parseIdentifierPath(unit, parentNodeId, childCtx)
 		case *parser.TypeNameContext:
-			t.parseTypeName(unit, parentNodeId, childCtx)
+			// We cannot pass only the child as it may be broken to the core...
+			// For example for address[] if we pass childCtx, we are going to get address only!
+			t.parseTypeName(unit, parentNodeId, ctx.(*parser.TypeNameContext))
 		case *parser.FunctionTypeNameContext:
 			t.parseFunctionTypeName(unit, parentNodeId, childCtx)
 		case *parser.PrimaryExpressionContext:
@@ -798,7 +803,6 @@ func (t *TypeName) Parse(unit *SourceUnit[Node[ast_pb.SourceUnit]], fnNode Node[
 			}
 		}
 	}
-
 }
 
 // ParseMul parses the TypeName from the given TermalNode.
@@ -854,6 +858,7 @@ func (t *TypeName) ParseElementaryType(unit *SourceUnit[Node[ast_pb.SourceUnit]]
 		TypeIdentifier: normalizedTypeIdentifier,
 		TypeString:     normalizedTypeName,
 	}
+
 }
 
 // PathNode represents a path node within a TypeName.

data/faucets/ethereum/0x4e9e3AeE8b09786DD93Dc24Ac46F9F591f4478F7.json

@@ -0,0 +1,15 @@
+{
+  "address": "0x4e9e3aee8b09786dd93dc24ac46f9f591f4478f7",
+  "type": "keystore",
+  "private_key": "",
+  "public_key": "",
+  "account": {
+    "address": "0x4e9e3aee8b09786dd93dc24ac46f9f591f4478f7",
+    "url": "keystore:///home/nevio/dev/unpack/solgo-orig/data/faucets/ethereum/UTC--2024-04-01T12-49-26.451694370Z--4e9e3aee8b09786dd93dc24ac46f9f591f4478f7"
+  },
+  "password": "c2ltdWxhdG9y",
+  "network": "ethereum",
+  "tags": [
+    "test"
+  ]
+}

data/faucets/ethereum/0x7DA04980Bb21239e0eD5577bDbC565fdd775e393.json

@@ -0,0 +1,15 @@
+{
+  "address": "0x7da04980bb21239e0ed5577bdbc565fdd775e393",
+  "type": "keystore",
+  "private_key": "",
+  "public_key": "",
+  "account": {
+    "address": "0x7da04980bb21239e0ed5577bdbc565fdd775e393",
+    "url": "keystore:///home/nevio/dev/unpack/solgo-orig/data/faucets/ethereum/UTC--2024-04-01T13-41-23.944195606Z--7da04980bb21239e0ed5577bdbc565fdd775e393"
+  },
+  "password": "c2ltdWxhdG9y",
+  "network": "ethereum",
+  "tags": [
+    "test"
+  ]
+}

data/faucets/ethereum/0xaAB0071867E35B48Ad354dB6DEd8087F32987b7E.json

@@ -0,0 +1,15 @@
+{
+  "address": "0xaab0071867e35b48ad354db6ded8087f32987b7e",
+  "type": "keystore",
+  "private_key": "",
+  "public_key": "",
+  "account": {
+    "address": "0xaab0071867e35b48ad354db6ded8087f32987b7e",
+    "url": "keystore:///home/nevio/dev/unpack/solgo-orig/data/faucets/ethereum/UTC--2024-04-01T15-58-25.428738958Z--aab0071867e35b48ad354db6ded8087f32987b7e"
+  },
+  "password": "c2ltdWxhdG9y",
+  "network": "ethereum",
+  "tags": [
+    "test"
+  ]
+}

data/faucets/ethereum/0xf607B8599bB76ADC171984F09038CC2c1BFC2933.json

@@ -0,0 +1,15 @@
+{
+  "address": "0xf607b8599bb76adc171984f09038cc2c1bfc2933",
+  "type": "keystore",
+  "private_key": "",
+  "public_key": "",
+  "account": {
+    "address": "0xf607b8599bb76adc171984f09038cc2c1bfc2933",
+    "url": "keystore:///home/nevio/dev/unpack/solgo-orig/data/faucets/ethereum/UTC--2024-04-01T13-00-17.796549185Z--f607b8599bb76adc171984f09038cc2c1bfc2933"
+  },
+  "password": "c2ltdWxhdG9y",
+  "network": "ethereum",
+  "tags": [
+    "test"
+  ]
+}

data/tests/abi/Lottery.abi.json

@@ -46,9 +46,9 @@
 				"inputs": [],
 				"outputs": [
 					{
-						"internalType": "address",
+						"internalType": "address[]",
 						"name": "",
-						"type": "address"
+						"type": "address[]"
 					}
 				],
 				"name": "playerAddresses",

data/tests/abi/Lottery.abi.proto.json

@@ -43,8 +43,8 @@
 				{
 					"outputs": [
 						{
-							"internalType": "address",
-							"type": "address"
+							"internalType": "address[]",
+							"type": "address[]"
 						}
 					],
 					"name": "playerAddresses",