Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST Bugfix: correctly parsing TypeNameContext - slice of types #183

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

0x19
Copy link
Contributor

@0x19 0x19 commented Apr 1, 2024

Well this one was nasty. Basically what I did is went through parser.TypeNameContext and created 3 different nodes instead of one, resulting in types such as address[] being address only. This had issues later on with ABI and constructor and what not. Fixed it now.

Fixing this error cascading resulted in different error while doing the resolution of the reference ids. -> I had id incremented where it should not be resulting in a reference not being able to find itself.

Besides that, now due to the [] types, storage is a bit more buggy. Applied patch for tests to pass but storage itself needs fix.

@0x19 0x19 added bug Something isn't working ast Abstract Syntax Tree labels Apr 1, 2024
@0x19 0x19 self-assigned this Apr 1, 2024
@0x19 0x19 merged commit a8fd6b4 into main Apr 1, 2024
6 of 7 checks passed
@0x19 0x19 deleted the type-name-fix branch April 1, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Abstract Syntax Tree bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant