New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1409]feat: add multicall to the sandbox #366

Merged

roman-gnativ merged 2 commits into main from romangnativ/reg-1409-add-multicall-to-sandbox

Sep 24, 2024

Merged

[REG-1409]feat: add multicall to the sandbox #366

merge with master

GitHub Advanced Security / Slither failed Sep 20, 2024 in 10s

19 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 high
4 low

Other Alerts:

14 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 54 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Calls inside a loop Low

Multicall3.aggregate(Multicall3.Call[]) has external calls inside a loop: (success,returnData[i]) = call.target.call(call.callData)

Check warning on line 54 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Low-level calls Warning

Low level call in Multicall3.aggregate(Multicall3.Call[]):
- (success,returnData[i]) = call.target.call(call.callData)

Check notice on line 74 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Calls inside a loop Low

Multicall3.tryAggregate(bool,Multicall3.Call[]) has external calls inside a loop: (result.success,result.returnData) = call.target.call(call.callData)

Check warning on line 74 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Low-level calls Warning

Low level call in Multicall3.tryAggregate(bool,Multicall3.Call[]):
- (result.success,result.returnData) = call.target.call(call.callData)

Check notice on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Calls inside a loop Low

Multicall3.aggregate3(Multicall3.Call3[]) has external calls inside a loop: (result.success,result.returnData) = calli.target.call(calli.callData)

Check warning on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Assembly usage Warning

Multicall3.aggregate3(Multicall3.Call3[]) uses assembly
- INLINE ASM

Check warning on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Low-level calls Warning

Low level call in Multicall3.aggregate3(Multicall3.Call3[]):
- (result.success,result.returnData) = calli.target.call(calli.callData)

Check warning on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3(Multicall3.Call3[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x04,0x0000000000000000000000000000000000000000000000000000000000000020)

Check warning on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3(Multicall3.Call3[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x24,0x0000000000000000000000000000000000000000000000000000000000000017)

Check warning on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3(Multicall3.Call3[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x44,0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000)

Check warning on line 133 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3(Multicall3.Call3[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x00,0x08c379a000000000000000000000000000000000000000000000000000000000)

Check failure on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Functions that send Ether to arbitrary destinations High

Multicall3.aggregate3Value(Multicall3.Call3Value[]) sends eth to arbitrary user
Dangerous calls:
- (result.success,result.returnData) = calli.target.call{value: val}(calli.callData)

Check notice on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Calls inside a loop Low

Multicall3.aggregate3Value(Multicall3.Call3Value[]) has external calls inside a loop: (result.success,result.returnData) = calli.target.call{value: val}(calli.callData)

Check warning on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Assembly usage Warning

Multicall3.aggregate3Value(Multicall3.Call3Value[]) uses assembly
- INLINE ASM

Check warning on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Low-level calls Warning

Low level call in Multicall3.aggregate3Value(Multicall3.Call3Value[]):
- (result.success,result.returnData) = calli.target.call{value: val}(calli.callData)

Check warning on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3Value(Multicall3.Call3Value[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x24,0x0000000000000000000000000000000000000000000000000000000000000017)

Check warning on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3Value(Multicall3.Call3Value[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x44,0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000)

Check warning on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3Value(Multicall3.Call3Value[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x04,0x0000000000000000000000000000000000000000000000000000000000000020)

Check warning on line 175 in contracts/mocks/Multicall3.sol

Code scanning / Slither

Too many digits Warning

Multicall3.aggregate3Value(Multicall3.Call3Value[]) uses literals with too many digits:
- mstore(uint256,uint256)(0x00,0x08c379a000000000000000000000000000000000000000000000000000000000)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REG-1409]feat: add multicall to the sandbox #366

[REG-1409]feat: add multicall to the sandbox #366

19 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Annotations

Re-running checks...