Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable coverage upload #1957

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 9, 2020

This is essentially a backport of python-trio/hip#219. It should fixes cases like #1956. I haven't touched AppVeyor as I'd like to move Windows tests to GitHub Actions next.

I'd suggest not squashing when merging to keep the rename commit separate.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 42452ac into urllib3:master Sep 9, 2020
@pquentin pquentin deleted the reliable-coverage-upload branch September 18, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants