-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.25] Backport all CI improvements to remove AppVeyor #1962
Conversation
8def2a4
to
3f69a3c
Compare
Before using upload_coverage.sh in GitHub Actions
While we do have a retry here, it's needed to make two queries, and cannot be wasted on a timeout due to continuous integration being slow.
3f69a3c
to
ab7ec1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to support both 1.25 and 1.26 for some time?
@@ -887,7 +887,7 @@ def socket_handler(listener): | |||
retries=1, | |||
release_conn=False, | |||
preload_content=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If including this is intended, there were two other CI improvements recently.
@pquentin No, this is just the last branch that still has mentions of AppVeyor and I've completely torn it down so if we were to need to make an emergency security release best to have this all ready to go :) Beyond that situation the |
Codecov Report
@@ Coverage Diff @@
## 1.25-series #1962 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 23 23
Lines 2009 2009
=============================================
Hits 2009 2009
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Backport of #1960 and #1957