Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.25] Backport all CI improvements to remove AppVeyor #1962

Merged
merged 8 commits into from
Sep 14, 2020

Conversation

sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Sep 13, 2020

Backport of #1960 and #1957

@sethmlarson sethmlarson requested a review from shazow as a code owner September 14, 2020 02:10
@sethmlarson sethmlarson changed the title [1.25] Migrate Windows CI to GitHub Actions [1.25] Backport all CI improvements to remove AppVeyor Sep 14, 2020
shazow
shazow previously approved these changes Sep 14, 2020
pquentin and others added 5 commits September 13, 2020 21:46
Before using upload_coverage.sh in GitHub Actions
While we do have a retry here, it's needed to make two queries, and
cannot be wasted on a timeout due to continuous integration being slow.
pquentin
pquentin previously approved these changes Sep 14, 2020
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to support both 1.25 and 1.26 for some time?

@@ -887,7 +887,7 @@ def socket_handler(listener):
retries=1,
release_conn=False,
preload_content=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If including this is intended, there were two other CI improvements recently.

@sethmlarson
Copy link
Member Author

sethmlarson commented Sep 14, 2020

@pquentin No, this is just the last branch that still has mentions of AppVeyor and I've completely torn it down so if we were to need to make an emergency security release best to have this all ready to go :)

Beyond that situation the 1.25-series branch shouldn't be needed.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1962 into 1.25-series will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           1.25-series     #1962   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               23        23           
  Lines             2009      2009           
=============================================
  Hits              2009      2009           
Flag Coverage Δ
#unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/urllib3/_collections.py 100.00% <ø> (ø)
src/urllib3/connection.py 100.00% <ø> (ø)
src/urllib3/exceptions.py 100.00% <ø> (ø)
src/urllib3/util/retry.py 100.00% <ø> (ø)
src/urllib3/util/timeout.py 100.00% <ø> (ø)
src/urllib3/util/wait.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3fb02...3937911. Read the comment docs.

@sethmlarson sethmlarson merged commit 9c54745 into urllib3:1.25-series Sep 14, 2020
@sethmlarson sethmlarson deleted the 1.25-gha-ci branch September 14, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants