Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Google Fonts is not GDPR compliant #695

Open
janmonschke opened this issue Oct 20, 2023 · 10 comments · Fixed by #750
Open

Loading Google Fonts is not GDPR compliant #695

janmonschke opened this issue Oct 20, 2023 · 10 comments · Fixed by #750
Assignees
Labels

Comments

@janmonschke
Copy link
Contributor

According to a German court, loading Google Fonts from Google's servers is not GDPR compliant and can lead to fines (source).

Therefore, bruno should embedd the Inter Google font that is currently loaded from Googles servers.

<link
href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap"
rel="stylesheet"
/>

NextJS 13 provides a helper module that lets you embedd the font: https://nextjs.org/docs/app/building-your-application/optimizing/fonts#google-fonts. Currently bruno use Next 12.

@grubersjoe
Copy link
Contributor

grubersjoe commented Oct 20, 2023

I have had good experience with fontsource packages: https://www.npmjs.com/package/@fontsource/inter. Might also be a consideration.

@janmonschke
Copy link
Contributor Author

@grubersjoe I agree that fontsource would solve this issue as well. Being in the next ecosystem, it might make sense to stick to the next modules though. (see #696)

@grubersjoe
Copy link
Contributor

Agreed. I forgot that Bruno uses Next internally.

@helloanoop
Copy link
Contributor

There is a v1.0.0 planned on Oct 29th 2023. Upgrading to a major version of Next with days away is a bit risky.

I welcome and support this PR. Will review this post V1 launch.
Meanwhile, if there is a smaller PR that can introduce the inline google font without upgrading next, please raise a PR for the same.

janmonschke added a commit to janmonschke/bruno that referenced this issue Oct 23, 2023
@janmonschke
Copy link
Contributor Author

@helloanoop Fixed it without the nexst update here: #750

@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented Jan 7, 2024

as of last version, bruno still tries to (maybe) download google fonts. as a user running from the privacy nightmare of postman to the bad ux insomnia, now i find myself trying bruno which vouches as a private app, but instead leaks my ip to google's empire.

it's literally on bruno's front page:
"Bruno is offline-only. There are no plans to add cloud-sync to Bruno, ever. We value your data privacy and believe it should stay on your device. Read our long-term vision here."

this should have highest priority and be fixed asap, or else people will lose trust in you from the very beginning

@grubersjoe
Copy link
Contributor

grubersjoe commented Jan 7, 2024

Maybe using the @fontsource/inter package wouldn't be the worst idea. Then it would work offline and Google is out if the equation.

janmonschke added a commit to janmonschke/bruno that referenced this issue Jan 7, 2024
@janmonschke
Copy link
Contributor Author

Agreed, I updated the PR because, in the meantime, conflicts occured in the package-lock file. #750

@helloanoop
Copy link
Contributor

Reopening this issue.
With Pr #750 , the Inter font loaded perfectly in development versions but was not working in production build.

@NiklasBr
Copy link
Contributor

Maybe use the system fonts if Inter is problematic?

@helloanoop helloanoop added the mid-term-goal Mid Term Goal label Dec 1, 2024
@helloanoop helloanoop self-assigned this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants