-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading Google Fonts is not GDPR compliant #695
Comments
I have had good experience with fontsource packages: https://www.npmjs.com/package/@fontsource/inter. Might also be a consideration. |
@grubersjoe I agree that fontsource would solve this issue as well. Being in the next ecosystem, it might make sense to stick to the next modules though. (see #696) |
Agreed. I forgot that Bruno uses Next internally. |
There is a v1.0.0 planned on Oct 29th 2023. Upgrading to a major version of Next with days away is a bit risky. I welcome and support this PR. Will review this post V1 launch. |
@helloanoop Fixed it without the nexst update here: #750 |
as of last version, bruno still tries to (maybe) download google fonts. as a user running from the privacy nightmare of postman to the bad ux insomnia, now i find myself trying bruno which vouches as a private app, but instead leaks my ip to google's empire. it's literally on bruno's front page: this should have highest priority and be fixed asap, or else people will lose trust in you from the very beginning |
Maybe using the @fontsource/inter package wouldn't be the worst idea. Then it would work offline and Google is out if the equation. |
Agreed, I updated the PR because, in the meantime, conflicts occured in the package-lock file. #750 |
Reopening this issue. |
Maybe use the system fonts if Inter is problematic? |
According to a German court, loading Google Fonts from Google's servers is not GDPR compliant and can lead to fines (source).
Therefore, bruno should embedd the
Inter
Google font that is currently loaded from Googles servers.bruno/packages/bruno-app/src/pages/_document.js
Lines 34 to 37 in f8f3880
NextJS 13 provides a helper module that lets you embedd the font: https://nextjs.org/docs/app/building-your-application/optimizing/fonts#google-fonts. Currently bruno use Next 12.
The text was updated successfully, but these errors were encountered: