Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-host Inter font to fix GDPR issue #750

Merged

Conversation

janmonschke
Copy link
Contributor

fixes #695

Description

  • Includes the Inter font from a local npm module instead of loading it from Google

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@janmonschke janmonschke changed the title Self-host Inter font to fox GDPR issue Self-host Inter font to fix GDPR issue Oct 23, 2023
@janmonschke janmonschke force-pushed the chore/include-inter-via-fontsource branch from 7913f34 to 94c7535 Compare January 7, 2024 19:05
@janmonschke
Copy link
Contributor Author

@helloanoop Since migrating to Next 13 feels out of scope for this "small" issue, let's go ahead and replace the fonts without the upgade. Context: #696 (comment)

@helloanoop helloanoop merged commit 4fbd2f0 into usebruno:main Aug 23, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @janmonschke !

@NiklasBr
Copy link
Contributor

Was this supposed to be in v1.28? I still see calls to googleapis…

image

@helloanoop
Copy link
Contributor

This needs to be fixed, This worked in local development version, but the fonts didn't load well in production version. We are looking into this. I gave reopened #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading Google Fonts is not GDPR compliant
3 participants