Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR #1102 - Fix test after updated dependencies #1185

Closed

Conversation

nelup20
Copy link
Contributor

@nelup20 nelup20 commented Dec 7, 2023

Description

The unit tests from PR #1102 should now be fixed after we updated the dependencies.
Not sure why it was having issues with requiring electron-store before 😅.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@nelup20 nelup20 marked this pull request as draft December 7, 2023 22:59
@nelup20
Copy link
Contributor Author

nelup20 commented Dec 7, 2023

Hey @helloanoop 👋, updating package-lock.json fixes these tests (I didn't properly check what was updated before, still quite a lot of deps that can be updated).
Should I add/update it in this PR? Didn't notice any breaking changes.

@nelup20 nelup20 closed this Dec 9, 2023
@nelup20
Copy link
Contributor Author

nelup20 commented Dec 9, 2023

Closed this since it's low priority anyways. I'm not sure which exact dependency fixes the test, since most deps have ^ version range (except the electron ones). Maybe we should switch to exact version or ~ versioning in the future to be more exact & avoid potential breaking changes.

@nelup20 nelup20 deleted the test/1102-fix_configure_request_text branch December 9, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant