Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR #1102 - Fix test after updated dependencies #1185

Closed
wants to merge 1 commit into from
Closed

Fix PR #1102 - Fix test after updated dependencies #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 12 additions & 22 deletions packages/bruno-electron/tests/network/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,15 @@
// damn jest throws an error when no tests are found in a file
// --passWithNoTests doesn't work
const { configureRequest } = require('../../src/ipc/network/index');

describe('dummy test', () => {
it('should pass', () => {
expect(true).toBe(true);
describe('index: configureRequest', () => {
it("Should add 'http://' to the URL if no protocol is specified", async () => {
const request = { method: 'GET', url: 'test-domain', body: {} };
await configureRequest(null, request, null, null, null, null);
expect(request.url).toEqual('http://test-domain');
});
});

// todo: fix this failing test
// const { configureRequest } = require('../../src/ipc/network/index');

// describe('index: configureRequest', () => {
// it("Should add 'http://' to the URL if no protocol is specified", async () => {
// const request = { method: 'GET', url: 'test-domain', body: {} };
// await configureRequest(null, request, null, null, null, null);
// expect(request.url).toEqual('http://test-domain');
// });

// it("Should NOT add 'http://' to the URL if a protocol is specified", async () => {
// const request = { method: 'GET', url: 'ftp://test-domain', body: {} };
// await configureRequest(null, request, null, null, null, null);
// expect(request.url).toEqual('ftp://test-domain');
// });
// });
it("Should NOT add 'http://' to the URL if a protocol is specified", async () => {
const request = { method: 'GET', url: 'ftp://test-domain', body: {} };
await configureRequest(null, request, null, null, null, null);
expect(request.url).toEqual('ftp://test-domain');
});
});
Loading