Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: image preview enhancement #385

Merged
merged 5 commits into from
Nov 1, 2022
Merged

feat: image preview enhancement #385

merged 5 commits into from
Nov 1, 2022

Conversation

Zeng1998
Copy link
Contributor

No description provided.

boojack
boojack reviewed Oct 31, 2022
View reviewed changes
web/src/components/Dialog/CommonDialog.tsx Outdated Show resolved Hide resolved
web/src/less/preview-image-carousel-dialog.less Outdated Show resolved Hide resolved
web/src/components/PreviewImageCarouselDialog.tsx Outdated Show resolved Hide resolved
boojack
boojack approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@boojack boojack merged commit 4246232 into usememos:main Nov 1, 2022
@Zeng1998 Zeng1998 deleted the feat_image_preview_enhancement branch November 1, 2022 01:30
@boojack boojack mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

@lqwakeup lqwakeup Awaiting requested review from lqwakeup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeng1998 @boojack