Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: view all images of a memo #393

Merged
merged 6 commits into from
Nov 2, 2022
Merged

feat: view all images of a memo #393

merged 6 commits into from
Nov 2, 2022

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Nov 1, 2022

@boojack
Copy link
Member

boojack commented Nov 1, 2022

Duplicated with #385

@hyoban
Copy link
Contributor Author

hyoban commented Nov 1, 2022

Duplicated with #385

is this only for memo resources?

@hyoban hyoban closed this Nov 1, 2022
@hyoban hyoban deleted the feat/view-all-images branch November 1, 2022 13:52
@hyoban hyoban restored the feat/view-all-images branch November 2, 2022 04:19
@hyoban hyoban reopened this Nov 2, 2022
@hyoban
Copy link
Contributor Author

hyoban commented Nov 2, 2022

2022-11-02.12-37-40.mp4

boojack
boojack approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack enabled auto-merge (squash) November 2, 2022 11:59
@boojack boojack merged commit 91a61e0 into main Nov 2, 2022
@hyoban hyoban deleted the feat/view-all-images branch November 2, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

@lqwakeup lqwakeup Awaiting requested review from lqwakeup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyoban @boojack @lqwakeup