Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCAL website - Events has a typo and 2 not working hyperlinks #1711

Closed
iMichaela opened this issue Mar 15, 2023 · 2 comments · Fixed by #1718
Closed

OSCAL website - Events has a typo and 2 not working hyperlinks #1711

iMichaela opened this issue Mar 15, 2023 · 2 comments · Fixed by #1718
Assignees
Labels

Comments

@iMichaela
Copy link
Contributor

Describe the bug

Page: OSCAL -> Events/_index.md has a typo in the Calendar section (see: appplication) . Also the 2 hyperlinks for the OSCAL DEFINE and OSCAL Model Engineering pages (bottom of the page) are wrong.

Need to either correct the links as follows or move the files in the events subdirectory.

https://pages.nist.gov/OSCAL/events/model-engineering-meeting/ should be https://pages.nist.gov/OSCAL/contribute/model-engineering-meeting/
https://pages.nist.gov/OSCAL/events/define-meeting/ should be https://pages.nist.gov/OSCAL/contribute/define-meeting/

Who is the bug affecting

readers

What is affected by this bug

Website

How do we replicate this issue

Clink on the links described above

Expected behavior (i.e. solution)

Need to either correct the links as follows or move the files in the events subdirectory.

https://pages.nist.gov/OSCAL/events/model-engineering-meeting/ should be https://pages.nist.gov/OSCAL/contribute/model-engineering-meeting/
https://pages.nist.gov/OSCAL/events/define-meeting/ should be https://pages.nist.gov/OSCAL/contribute/define-meeting/

Other comments

No response

@iMichaela iMichaela added the bug label Mar 15, 2023
@aj-stein-nist
Copy link
Contributor

Thanks for the report and nice find. I am pretty annoyed the link checker did not find the bad link targets, but I guess we figure out why that was/is another time.

@aj-stein-nist
Copy link
Contributor

I will work on this to clear my head at the end of the day. It is likely blocked by #1698 for the actual publication to the site, but still a quick thing to fix.

@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Mar 17, 2023
@aj-stein-nist aj-stein-nist linked a pull request Mar 17, 2023 that will close this issue
7 tasks
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Mar 18, 2023
@aj-stein-nist aj-stein-nist moved this from Under Review to Reviewer Approved in NIST OSCAL Work Board Mar 20, 2023
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in NIST OSCAL Work Board Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants