Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issues on events page #1718

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Mar 17, 2023

Committer Notes

Correct typo and fix links for #1711.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist requested a review from a team March 17, 2023 23:58
@aj-stein-nist aj-stein-nist self-assigned this Mar 17, 2023
@aj-stein-nist aj-stein-nist linked an issue Mar 17, 2023 that may be closed by this pull request
@aj-stein-nist aj-stein-nist marked this pull request as ready for review March 18, 2023 00:00
@aj-stein-nist
Copy link
Contributor Author

Final merge and publication blocked by #1698 but still good to go and review regardless in the interim.

Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple PRs are the best, LGTM

@aj-stein-nist
Copy link
Contributor Author

Simple PRs are the best, LGTM

Thanks, we still need to handle CI/CD problems in another issue before merged.

Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@aj-stein-nist
Copy link
Contributor Author

I am going to merge this to test in conjunction with #1721. If the pages don't deploy I will be forced to work through it.

@aj-stein-nist aj-stein-nist merged commit 9a6481f into main Mar 24, 2023
@aj-stein-nist aj-stein-nist deleted the 1711-oscal-website-events-has-a-typo-and-2-not-working-hyperlinks branch March 24, 2023 21:27
@aj-stein-nist
Copy link
Contributor Author

What a surprise, it didn't work. Away we go, more debugging to come and notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSCAL website - Events has a typo and 2 not working hyperlinks
3 participants