Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests in tests/common/util.rs fails on OpenBSD 7.5 #6348

Closed
jadijadi opened this issue May 4, 2024 · 1 comment · Fixed by #6349 or #6368
Closed

tests in tests/common/util.rs fails on OpenBSD 7.5 #6348

jadijadi opened this issue May 4, 2024 · 1 comment · Fixed by #6349 or #6368

Comments

@jadijadi
Copy link
Contributor

jadijadi commented May 4, 2024

The cargo test fails on OpenBSD due to not supporting xattrs.

failures:                                                                                                                
                                                            
---- common::util::tests::test_compare_xattrs stdout ----   
thread 'common::util::tests::test_compare_xattrs' panicked at tests/common/util.rs:3628:56:                              
called `Result::unwrap()` on an `Err` value: Custom { kind: Unsupported, error: UnsupportedPlatformError }               
                                                                                                                         
                                                                                                                         
failures:                                                                                                                
    common::util::tests::test_compare_xattrs    

There are several other failing tests on utils section on OpenBSD but this one is kind of more important because its in the tests/common/util.rs and when it breaks tests do not continue to by-util section.

jadijadi added a commit to jadijadi/coreutils that referenced this issue May 4, 2024
The test_compare_xattrs test fails on OpenBSD because OpenBSD does
not support xattrs. Disabling this test for target_os = openbsd
resolved the issue.

Fixes uutils#6348
jadijadi added a commit to jadijadi/coreutils that referenced this issue May 5, 2024
The test_compare_xattrs test fails on OpenBSD because OpenBSD does
not support xattrs. Disabling this function and its test for
target_os = openbsd resolves the issue.

Fixes uutils#6348
jadijadi added a commit to jadijadi/coreutils that referenced this issue May 6, 2024
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes uutils#6348
@jadijadi
Copy link
Contributor Author

jadijadi commented May 6, 2024

Opening this to prevent creating a closely related case.
After remove the actual compare_xattrs based on PRs discussions (which looks like a good decision), OpenBSD cargo test for mv and cp also breaks because they do have tests based on that function. So I will send another PR to add the target_os is not openbsd condition to these tests too.

@BenWiederhake BenWiederhake reopened this May 6, 2024
jadijadi added a commit to jadijadi/coreutils that referenced this issue May 9, 2024
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes uutils#6348
jadijadi added a commit to jadijadi/coreutils that referenced this issue May 9, 2024
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes uutils#6348
BenWiederhake pushed a commit that referenced this issue May 9, 2024
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes #6348
WaleedKhamees pushed a commit to WaleedKhamees/coreutils that referenced this issue May 20, 2024
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes uutils#6348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants