Disabling xattrs tests on OpenBSD #6349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWiederhake
requested changes
May 4, 2024
The test_compare_xattrs test fails on OpenBSD because OpenBSD does not support xattrs. Disabling this function and its test for target_os = openbsd resolves the issue. Fixes uutils#6348
jadijadi
force-pushed
the
disabling-xattrs-openbsd
branch
from
c42b0eb to
19d42c0
Compare
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
May 5, 2024
There was a problem hiding this comment.
LGTM, and the implicit "test" is that building now works :D
For some reason, this feels still a bit strange to me; I just don't feel confident with the cfg-conditions being different everywhere, and I don't have a good overview what combinations are possible.
Dear other maintainers, feel free to merge this if you think this is the right cfg-condition. (Maybe I'll merge it later.)
Ping @sylvestre
|
Thanks. Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_compare_xattrs test fails on OpenBSD because OpenBSD does not support xattrs. Disabling this test for
target_os = openbsdresolved the issue.Fixes #6348