Add support for SL Micro 6.1 hosts #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srbarrios
previously approved these changes
Jan 16, 2025
ktsamis
approved these changes
Jan 16, 2025
NamelessOne91
approved these changes
Jan 16, 2025
maximenoel8
requested changes
Jan 16, 2025
There was a problem hiding this comment.
slemicro61o is not supported by user_data.yaml but combustion. Those changes need to be impacted in combustion (if needed).
There was a problem hiding this comment.
Double check if what is already in combustion is not enough.
There was a problem hiding this comment.
Seems like with combustion, changes for transactional systems in user_data.yaml applies the same changes for the second time (?)
fix done
There was a problem hiding this comment.
If it's the case, something wrong in sumaform.
In sumaform logic we clearly disable user_data when using combustion
sumaform/backend_modules/libvirt/host/main.tf
Line 138 in aadfe2e
srbarrios
dismissed
their stale review
I overlooked some good points that Maxime caught.
nodeg
reviewed
Jan 20, 2025
12 tasks
maximenoel8
reviewed
Jan 20, 2025
maximenoel8
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This is the continuation of aadfe2e to make it more aligned with #1583 fulfilling requirements in https://github.com/SUSE/spacewalk/issues/26216.
To be verified after deployment:
salt/default/sshd.sls