Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SL Micro 6.1 hosts #1771

Merged
merged 6 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README_ADVANCED.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Legal values for work-in-progress software are:
- `4.3-VM-nightly` (corresponds to the VM image in the Build Service project Devel:Galaxy:Manager:4.3)
- `4.3-beta` (corresponds to the Build Service project SUSE:SLE-15-SP4:Update:Products:Manager43)
- `5.0-nightly` (corresponds to the Build Service project Devel:Galaxy:Manager:5.0)
- `head` (corresponds to the Build Service project Devel:Galaxy:Manager:Head, uses SLE Micro as the base image for server)
- `head` (corresponds to the Build Service project Devel:Galaxy:Manager:Head, uses SL Micro 6.1 as the base image for server)
- `uyuni-master` (corresponds to the Build Service project systemsmanagement:Uyuni:Master, for `server` and `proxy` only works with openSUSE Leap image)

**Important:** sumaform only supports containerized deployments for SUSE Manager versions 5.0 and later.
Expand Down
2 changes: 1 addition & 1 deletion backend_modules/libvirt/host/combustion
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ PACKAGES="$PACKAGES mgradm mgrctl mgradm-bash-completion mgrctl-bash-completion"
%{ endif }

%{ if container_proxy }
PACKAGES="$PACKAGES mgrpxy"
PACKAGES="$PACKAGES mgrpxy"
%{ endif }

%{ if install_salt_bundle }
Expand Down
2 changes: 2 additions & 0 deletions modules/controller/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ module "controller" {
slemicro55_sshminion = length(var.slemicro55_sshminion_configuration["hostnames"]) > 0 ? var.slemicro55_sshminion_configuration["hostnames"][0] : null
slmicro60_minion = length(var.slmicro60_minion_configuration["hostnames"]) > 0 ? var.slmicro60_minion_configuration["hostnames"][0] : null
slmicro60_sshminion = length(var.slmicro60_sshminion_configuration["hostnames"]) > 0 ? var.slmicro60_sshminion_configuration["hostnames"][0] : null
slmicro61_minion = length(var.slmicro61_minion_configuration["hostnames"]) > 0 ? var.slmicro61_minion_configuration["hostnames"][0] : null
slmicro61_sshminion = length(var.slmicro61_sshminion_configuration["hostnames"]) > 0 ? var.slmicro61_sshminion_configuration["hostnames"][0] : null
centos7_minion = length(var.centos7_minion_configuration["hostnames"]) > 0 ? var.centos7_minion_configuration["hostnames"][0] : null
centos7_sshminion = length(var.centos7_sshminion_configuration["hostnames"]) > 0 ? var.centos7_sshminion_configuration["hostnames"][0] : null
centos7_client = length(var.centos7_client_configuration["hostnames"]) > 0 ? var.centos7_client_configuration["hostnames"][0] : null
Expand Down
22 changes: 14 additions & 8 deletions modules/controller/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@ variable "minion_configuration" {
}
}

variable "slemicro_minion_configuration" {
description = "use module.<SLE_MICRO_MINION_NAME>.configuration, see main.tf.libvirt-testsuite.example"
default = {
ids = []
hostnames = []
}
}

variable "buildhost_configuration" {
description = "use module.<BUILDHOST_NAME>.configuration, see main.tf.libvirt-testsuite.example"
default = {
Expand Down Expand Up @@ -352,13 +344,27 @@ variable "slmicro60_minion_configuration" {
}
}

variable "slmicro61_minion_configuration" {
description = "use module.<SLMICRO61_MINION>.configuration, see main.tf.libvirt-testsuite.example"
default = {
hostnames = []
}
}

variable "slmicro60_sshminion_configuration" {
description = "use module.<SLMICRO60_SSHMINION>.configuration, see main.tf.libvirt-testsuite.example"
default = {
hostnames = []
}
}

variable "slmicro61_sshminion_configuration" {
description = "use module.<SLMICRO61_SSHMINION>.configuration, see main.tf.libvirt-testsuite.example"
default = {
hostnames = []
}
}

variable "centos7_minion_configuration" {
description = "use module.<CENTOS7_MINION>.configuration, see main.tf.libvirt-testsuite.example"
default = {
Expand Down
2 changes: 0 additions & 2 deletions modules/cucumber_testsuite/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,6 @@ module "controller" {
client_configuration = contains(local.hosts, "suse_client") ? module.suse_client.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] }
minion_configuration = contains(local.hosts, "suse_minion") ? module.suse_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] }
sshminion_configuration = contains(local.hosts, "suse_sshminion") ? module.suse_sshminion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] }
slemicro_minion_configuration = contains(local.hosts, "slemicro_minion") ? module.slemicro_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] }
# TODO: rename redhat_configuration and debian_configuration to rhlike_configuration and deblike_configuration once the renaming is done: https://github.com/SUSE/spacewalk/issues/25062
redhat_configuration = contains(local.hosts, "rhlike_minion") ? module.rhlike_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] }
debian_configuration = contains(local.hosts, "deblike_minion") ? module.deblike_minion.configuration : { hostnames = [], ids = [], ipaddrs = [], macaddrs = [], private_macs = [] }
Expand Down Expand Up @@ -504,7 +503,6 @@ output "configuration" {
server = var.container_server ? module.server_containerized[0].configuration : module.server[0].configuration
proxy = var.container_proxy ? module.proxy_containerized[0].configuration : module.proxy[0].configuration
suse_client = module.suse_client.configuration
slemicro_minion = module.slemicro_minion.configuration
suse_minion = module.suse_minion.configuration
suse_sshminion = module.suse_sshminion.configuration
rhlike_minion = module.rhlike_minion.configuration
Expand Down
2 changes: 1 addition & 1 deletion modules/cucumber_testsuite/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ variable "name_prefix" {

variable "images" {
description = "list of images to be uploaded to the libvirt host, leave default for all"
default = ["centos7o", "opensuse155o", "leapmicro55o", "slemicro55o", "rocky8o", "rocky9o", "sles12sp5o", "sles15sp2o", "sles15sp3o", "sles15sp4o", "sles15sp5o", "sles15sp6o", "ubuntu2004o", "ubuntu2204o", "suma43VM-ign"]
default = ["centos7o", "opensuse155o", "leapmicro55o", "slemicro55o", "slmicro60o", "slmicro61o", "rocky8o", "rocky9o", "sles12sp5o", "sles15sp2o", "sles15sp3o", "sles15sp4o", "sles15sp5o", "sles15sp6o", "ubuntu2004o", "ubuntu2204o", "suma43VM-ign"]
}

variable "main_disk_size" {
Expand Down
2 changes: 2 additions & 0 deletions salt/controller/bashrc
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export VIRTHOST_KVM_PASSWORD="linux" {% else %}# no KVM host defined {% endif %}
{% if grains.get('slemicro55_sshminion') | default(false, true) %}export SLEMICRO55_SSHMINION="{{ grains.get('slemicro55_sshminion') }}" {% else %}# no SLEMICRO55 ssh minion defined {% endif %}
{% if grains.get('slmicro60_minion') | default(false, true) %}export SLMICRO60_MINION="{{ grains.get('slmicro60_minion') }}" {% else %}# no SLMICRO60 minion defined {% endif %}
{% if grains.get('slmicro60_sshminion') | default(false, true) %}export SLMICRO60_SSHMINION="{{ grains.get('slmicro60_sshminion') }}" {% else %}# no SLMICRO60 ssh minion defined {% endif %}
{% if grains.get('slmicro61_minion') | default(false, true) %}export SLMICRO61_MINION="{{ grains.get('slmicro61_minion') }}" {% else %}# no SLMICRO61 minion defined {% endif %}
{% if grains.get('slmicro61_sshminion') | default(false, true) %}export SLMICRO61_SSHMINION="{{ grains.get('slmicro61_sshminion') }}" {% else %}# no SLMICRO61 ssh minion defined {% endif %}
{% if grains.get('alma8_minion') | default(false, true) %}export ALMA8_MINION="{{ grains.get('alma8_minion') }}" {% else %}# no ALMA8 minion defined {% endif %}
{% if grains.get('alma8_sshminion') | default(false, true) %}export ALMA8_SSHMINION="{{ grains.get('alma8_sshminion') }}" {% else %}# no ALMA8 ssh minion defined {% endif %}
{% if grains.get('alma9_minion') | default(false, true) %}export ALMA9_MINION="{{ grains.get('alma9_minion') }}" {% else %}# no ALMA9 minion defined {% endif %}
Expand Down
1 change: 1 addition & 0 deletions salt/mirror/etc/minima.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ scc:
# SL Micro
- SL-Micro-6.0-Pool
- SL-Micro-6.0-Updates
- SL-Micro-6.1-Pool
# SLE 15-SP4 Products
- SLE-Product-SLES15-SP4-Pool
- SLE-Product-SLES15-SP4-Updates
Expand Down
21 changes: 20 additions & 1 deletion salt/repos/client_tools.sls
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,26 @@ tools_update_repo:

{% elif grains['osfullname'] == 'SL-Micro' %}

{# TODO: add SL Micro 6 #}
{% if not grains.get('product_version') or not grains.get('product_version').startswith('uyuni-') %} {# Released Tools repos #}

tools_pool_repo:
pkgrepo.managed:
- baseurl: http://{{ grains.get("mirror") | default("download.suse.de/ibs", true) }}/SUSE/Products/SUSE-Manager-Tools-For-SL-Micro/6/{{ grains.get("cpuarch") }}/product/
- refresh: True

{% else %}

tools_pool_repo:
pkgrepo.managed:
- baseurl: http://{{ grains.get("mirror") | default("downloadcontent.opensuse.org", true) }}/repositories/systemsmanagement:/Uyuni:/Stable:/SLE15-Uyuni-Client-Tools/SLE_15/
- refresh: True

{% endif %} {# Released Tools repos #}

tools_additional_repo:
pkgrepo.managed:
- baseurl: http://{{ grains.get("mirror") | default("download.suse.de", true) }}/ibs/Devel:/Galaxy:/Manager:/Head:/SL-Micro-6-SUSE-Manager-Tools/SL-Micro6/
- refresh: True

{% elif grains['osfullname'] == 'SLE Micro' %}

Expand Down
2 changes: 1 addition & 1 deletion salt/repos/testsuite.sls
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ uyuni_key_for_fake_packages:
- name: transactional-update -c run rpm --import http://{{ grains.get("mirror") | default("minima-mirror-ci-bv.mgr.prv.suse.net", true) }}/uyuni.key
{% endif %}

{% if not (grains['osfullname'] in ['SL-Micro'] and grains['osrelease'] in ['6.0']) and not (grains['osfullname'] in ['openSUSE Leap Micro'] and grains['osrelease'] in ['5.5']) %}
maximenoel8 marked this conversation as resolved.
Show resolved Hide resolved
{% if not (grains['osfullname'] in ['SLE-Micro', 'SL-Micro', 'openSUSE Leap Micro']) %}
test_repo_rpm_pool:
pkgrepo.managed:
- baseurl: http://{{ grains.get("mirror") | default("downloadcontent.opensuse.org", true) }}/repositories/systemsmanagement:/Uyuni:/Test-Packages:/Pool/rpm/
Expand Down
3 changes: 3 additions & 0 deletions salt/salt_testenv/salt_bundle_package.sls
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
{% if grains['osrelease'] == '6.0' %}
{% set repo_path = 'SLMicro60' %}
{% endif %}
{% if grains['osrelease'] == '6.1' %}
{% set repo_path = 'SLMicro61' %}
{% endif %}
{% endif %}

{% if grains['salt_obs_flavor'] != 'saltstack' %}
Expand Down
2 changes: 1 addition & 1 deletion salt/server_containerized/testsuite.sls
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ repo_key_import:
- onchanges:
- file: galaxy_key_copy_host

# needed for SL Micro 6.0 maintenance updates coming from staging e.g.
# needed for SL Micro maintenance updates coming from staging e.g.
# https://download.suse.de/ibs/SUSE:/ALP:/Source:/Standard:/1.0:/Staging:/Z/standard/
suse_staging_key_copy_host:
file.managed:
Expand Down
Loading