Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark CRUD buttons as default to handle them properly #5179

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

web-padawan
Copy link
Member

Description

Added a flag that was introduced by vaadin/web-components#5955
This indicates that the button created by the Flow counterpart is the default one.

Type of change

  • Fix

@web-padawan web-padawan requested a review from sissbruecker June 22, 2023 14:05
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sissbruecker sissbruecker merged commit 089ac35 into main Jun 22, 2023
@sissbruecker sissbruecker deleted the fix/crud-buttons branch June 22, 2023 14:30
vaadin-bot pushed a commit that referenced this pull request Jun 22, 2023
* fix: mark CRUD buttons as default to handle them properly

* add IT for default button texts

---------

Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker added a commit that referenced this pull request Jun 22, 2023
)

* fix: mark CRUD buttons as default to handle them properly

* add IT for default button texts

---------

Co-authored-by: Serhii Kulykov <[email protected]>
Co-authored-by: Sascha Ißbrücker <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants