fix!: only modify text content for default slotted buttons #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/crud-slot-controller
branch
from
ab20a40 to
19cd775
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Jun 12, 2023
sissbruecker
pushed a commit
that referenced
this pull request
Jun 22, 2023
(cherry picked from commit 03e5c22)
sissbruecker
added a commit
that referenced
this pull request
Jun 22, 2023
…6030) (cherry picked from commit 03e5c22) Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #5946 (comment) - see code example there.
Similar to #5146 that introduced
_isDefaultflags tovaadin-uploadslot controllers for using by Flow counterpart.This PR makes it possible for the
vaadin-crudweb component users to actually pass custom slotted button elements.Type of change
Overview
Before
i18npropertythemeattribute was always set to use the value defined by the controllerAfter
_isDefaultproperty on the slotted button,vaadin-crudbehaves as beforethemeattribute aren't changed so user can set them