Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-petclinic is not compatible with vaadin 24.6.0.beta3 #2955

Closed
Tracked by #7057
ZheSun88 opened this issue Dec 5, 2024 · 4 comments · Fixed by #2956
Closed
Tracked by #7057

spring-petclinic is not compatible with vaadin 24.6.0.beta3 #2955

ZheSun88 opened this issue Dec 5, 2024 · 4 comments · Fixed by #2956

Comments

@ZheSun88
Copy link
Contributor

ZheSun88 commented Dec 5, 2024

Description of the bug

when build the spring-petclinic, i got this error

Description:

The bean 'endpointObjectMapper', defined in class path resource [org/springframework/boot/actuate/autoconfigure/endpoint/jackson/JacksonEndpointAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [com/vaadin/hilla/EndpointControllerConfiguration.class] and overriding is disabled.

Expected behavior

project builds ok

Minimal reproducible example

  • git clone [email protected]:spring-petclinic/spring-petclinic-vaadin-flow.git
  • update vaadin.version to 24.6.0.beta3
  • add vaadin prerelease repo
    • <repository><id>v</id><url>https://maven.vaadin.com/vaadin-prereleases</url></repository>
    • <pluginRepository><id>v</id><url>https://maven.vaadin.com/vaadin-prereleases</url></pluginRepository>
  • ./mvnw spring-boot:run

Versions

  • Vaadin / Flow version: 24.6.0.beta3/24.6.0.beta7
  • Java version: 17 (should not matter)
@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Dec 5, 2024

one guess is about the version mismatch on jackson.version between
flow 24.6 (jackson 2.18)
spring 3.4 (jackson 2.18)
hilla 24.6 (jackson 2.17)

but hilla cannot be upgraded as swagger-core is not compatible with latest jackson swagger-api/swagger-core#4755

@taefi
Copy link
Contributor

taefi commented Dec 5, 2024

No, this is related to some bean that is introduced recently, and it seems it clashes with the one spring-actuator defines. We should rename that in Hilla.

@taefi taefi transferred this issue from vaadin/flow Dec 5, 2024
@taefi taefi self-assigned this Dec 5, 2024
taefi added a commit that referenced this issue Dec 5, 2024
Having Hilla related beans prefixed with hilla
prevents clash with other framework or user
beans.

Fixes #2955
@taefi taefi closed this as completed in 2f4bf98 Dec 5, 2024
@taefi taefi added bug Something isn't working hilla Issues related to Hilla labels Dec 5, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.7.0.alpha2 and is also targeting the upcoming stable 24.7.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.6.0.beta6 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants