Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: rename Hilla's endpointObjectMapper to prevent bean name clashes #2956

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Dec 5, 2024

Having Hilla related beans prefixed with hilla
prevents clash with other framework or user
beans.

Fixes #2955

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Having Hilla related beans prefixed with hilla
prevents clash with other framework or user
beans.

Fixes #2955
Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (b0da2f7) to head (2ebd3ca).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2956   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          84       84           
  Lines        3156     3156           
  Branches      769      769           
=======================================
  Hits         2926     2926           
  Misses        179      179           
  Partials       51       51           
Flag Coverage Δ
unittests 92.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review December 5, 2024 11:30
@platosha
Copy link
Contributor

platosha commented Dec 5, 2024

Looks like a necessary but braking change. Let me mark it with the exclamation mark to then list in the release notes.

@platosha platosha changed the title fix: rename Hilla's endpointObjectMapper to prevent bean name clashes fix!: rename Hilla's endpointObjectMapper to prevent bean name clashes Dec 5, 2024
@taefi taefi merged commit 2f4bf98 into main Dec 5, 2024
15 checks passed
@taefi taefi deleted the taefi/fix-endpoint-mapper-bean-conflict branch December 5, 2024 11:36
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.7.0.alpha2 and is also targeting the upcoming stable 24.7.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.6.0.beta6 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring-petclinic is not compatible with vaadin 24.6.0.beta3
3 participants