Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use quarkus integration tests and generate screenshots on failure #34

Closed
wants to merge 17 commits into from

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Sep 9, 2021

Quarkus integration tests should be used instead of unit tests.
Screenshot on failure extension is added.

fixes #23

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Denis Anisimov added 2 commits September 8, 2021 19:45
Quarkus integration tests should be used instead of unit tests.
Screenshot on failure extension is added.

fixes #23
caalador
caalador previously approved these changes Sep 9, 2021
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the build fails with:

Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: io/quarkus/bootstrap/runner/QuarkusEntryPoint has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Which would indicate that something is trying to execute using jdk8 when jdk11 should be used

@denis-anisimov
Copy link
Author

Which would indicate that something is trying to execute using jdk8 when jdk11 should be used

yes, and I have no idea what

@denis-anisimov
Copy link
Author

This PR is failing because of bug in Quarkus plugin :quarkusio/quarkus#20049.

Let's don't close this and wait when the fix (which is already provided) will be included in the release.
Once it's released the PR van be revalidated and merged.
Nothing else can be done at this moment.

Denis and others added 2 commits September 10, 2021 11:35
* chore: add release profile, javadocs and source generation

Co-authored-by: ZheSun88 <[email protected]>
@mshabarov
Copy link
Contributor

@denis-anisimov the ticket is closed with 2.3.0.CR1 milestone, so maybe the new version is already available.

@caalador
Copy link
Contributor

caalador commented Oct 5, 2021

Seems ok and by the one failing run seems to work as expected, but there is some issue with the rebase as the PR seems to show a bunch of changes that are not from this fix.

@denis-anisimov
Copy link
Author

Closed in favor of #39

@denis-anisimov denis-anisimov deleted the 23-screenshots branch October 6, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IT tests are lacking snapshots on failure
3 participants