Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use quarkus integration tests and generate screenshots on failure #39

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Oct 6, 2021

Quarkus integration tests should be used instead of unit tests.
Screenshot on failure extension is added.

fixes #23

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Denis Anisimov added 3 commits October 6, 2021 10:28
@denis-anisimov denis-anisimov changed the title 23 screenshots new fix: use quarkus integration tests and generate screenshots on failure Oct 6, 2021
caalador
caalador previously approved these changes Oct 6, 2021
@caalador caalador enabled auto-merge (squash) October 6, 2021 07:33
…from the very beginning (thank you Github for the merge nightmare).
@caalador caalador merged commit 6743451 into master Oct 6, 2021
@caalador caalador deleted the 23-screenshots-new branch October 6, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IT tests are lacking snapshots on failure
2 participants