fix: reduce chart re-draws for update() #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
hdamr
reviewed
Oct 12, 2021
| } | ||
| } | ||
|
|
||
| __updateOrAddSeriesInstance(seriesOptions, position) { | ||
| __updateOrAddSeriesInstance(seriesOptions, position, redraw) { |
There was a problem hiding this comment.
There is another call to this method on line 1019 that needs to be updated.
There was a problem hiding this comment.
It is a bit beyond the scope of the current fix so I would rather not change the __addSeries method in this PR, but do it in a separate PR when backporting vaadin/web-components#2348. 👍
vursen
changed the title
hdamr
previously approved these changes
Oct 13, 2021
7 tasks
yuriy-fix
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the fix introduced in vaadin/web-components#2508 to reduce the number of chart re-draws for the
update()method.Type of change
Checklist