fix: reduce charts initialization time up to ~2x #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriy-fix
reviewed
Oct 13, 2021
vursen
force-pushed
the
perf/charts/reduce-initialization-time
branch
from
b72e591 to
6135ae0
Compare
7 tasks
yuriy-fix
previously approved these changes
Oct 13, 2021
vursen
force-pushed
the
perf/charts/reduce-initialization-time
branch
from
71841da to
abc9bcc
Compare
vursen
commented
Oct 14, 2021
| @@ -136,7 +136,7 @@ | |||
| const container = fixture('container'); | |||
| const unattachedChart = document.createElement('vaadin-chart'); | |||
| unattachedChart.update({title: {text: 'Awesome chart'}}); | |||
| setTimeout(() => { | |||
| Polymer.RenderStatus.beforeNextRender(chart, () => { | |||
There was a problem hiding this comment.
Had to replace setTimeout with beforeNextRender as otherwise, the test was failing on iOS.
yuriy-fix
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the fix introduced in vaadin/web-components#2348 to reduce the charts initialization time up to ~2x.
Type of change
Checklist